Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The player doesn't lose ore when paying for Jesse #102

Closed
AmProsius opened this issue Feb 2, 2021 · 1 comment · Fixed by #137
Closed

The player doesn't lose ore when paying for Jesse #102

AmProsius opened this issue Feb 2, 2021 · 1 comment · Fixed by #137
Labels
compatibility: easy This issue is easy to make compatible. impl: hook script func This issue requires hooking script functions. provided fix This issue has a fix provided in the comments. type: session fix The fix for this issues is persistent across a session. validation: validated This issue is still present even with Systempack/Union.
Milestone

Comments

@AmProsius
Copy link
Owner

AmProsius commented Feb 2, 2021

Describe the bug
The player doesn't lose 10 ore if he chooses to pay for Jesse.

Expected behavior
The player now correctly loses 10 ore if he chooses to pay for Jesse.

@AmProsius AmProsius changed the title The player doesn't lose Ore when paying for Jesse The player doesn't lose ore when paying for Jesse Feb 4, 2021
@szapp szapp added compatibility: difficult This issue is difficult to make compatible. type: session fix The fix for this issues is persistent across a session. labels Feb 8, 2021
@AmProsius
Copy link
Owner Author

if (Npc_HasItems(other,itminugget) >= 10)
{
AI_Output (other, self,"Info_Bloodwyn_PayForJesse_15_03"); //No - I am paying for him. So take his 10 ore and leave him be!
AI_Output (self, other,"Info_Bloodwyn_PayForJesse_08_04"); //Okay, man, if that's the way you want it.
Jesse_PayForMe = LOG_SUCCESS;
}

changed to

    if (Npc_HasItems(other,itminugget) >= 10)
    {
        AI_Output (other, self,"Info_Bloodwyn_PayForJesse_15_03"); //No - I am paying for him. So take his 10 ore and leave him be!
        AI_Output (self, other,"Info_Bloodwyn_PayForJesse_08_04"); //Okay, man, if that's the way you want it.
        B_GiveInvItems (other, self, itminugget, 10);
        Jesse_PayForMe = LOG_SUCCESS;
    }

@AmProsius AmProsius added provided fix This issue has a fix provided in the comments. validation: validated This issue is still present even with Systempack/Union. labels Feb 11, 2021
@AmProsius AmProsius added this to To Do in v1.0.0 Feb 13, 2021
@AmProsius AmProsius added this to the v1.0.0 milestone Feb 13, 2021
@szapp szapp added compatibility: easy This issue is easy to make compatible. and removed compatibility: difficult This issue is difficult to make compatible. labels Feb 13, 2021
szapp added a commit that referenced this issue Feb 22, 2021
@szapp szapp moved this from To Do to In Progress in v1.0.0 Feb 22, 2021
v1.0.0 automation moved this from In Progress to Done Feb 24, 2021
AmProsius added a commit that referenced this issue Feb 24, 2021
@AmProsius AmProsius added this to Dialog: Give items in Fix templates Mar 3, 2021
@szapp szapp added the impl: hook script func This issue requires hooking script functions. label Mar 16, 2021
szapp added a commit that referenced this issue Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility: easy This issue is easy to make compatible. impl: hook script func This issue requires hooking script functions. provided fix This issue has a fix provided in the comments. type: session fix The fix for this issues is persistent across a session. validation: validated This issue is still present even with Systempack/Union.
Projects
Fix templates
Add item transaction to dialog
v1.0.0
  
Done
Development

Successfully merging a pull request may close this issue.

2 participants