Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lens flares in the swampweed cave #116

Merged
merged 6 commits into from Jan 27, 2022
Merged

Lens flares in the swampweed cave #116

merged 6 commits into from Jan 27, 2022

Conversation

AmProsius
Copy link
Owner

@AmProsius AmProsius commented Sep 13, 2021

Describe the bug
There are lens flares in Jacko's swampweed cave even though it's a closed cave.

Expected behavior
There are no longer lens flares in Jacko's swampweed cave.

Additional context
The nearest waypoint is LOCATION_23_CAVE_1_02.

Screenshot
ScreenShot_2021_2_12_22_22_39

@AmProsius AmProsius added the validation: validated This issue is still present even with Systempack/Union. label Feb 12, 2021
@AmProsius AmProsius changed the title Sun rays in the swampweed cave Lens flares in the swampweed cave Feb 12, 2021
@szapp szapp added the type: world bug This issue requires editing properties of objects in the game world. label Feb 13, 2021
@N1kX94
Copy link

N1kX94 commented Apr 2, 2021

Vob in zen file

[% zCVobLight:zCVob 46080 10951]
			pack=int:0
			presetName=string:FIRE
			bbox3DWS=rawFloat:-44624.2109 -559.977966 -4529.67432 -43024.2109 1040.02209 -2929.67432 
			trafoOSToWSRot=raw:07b8643f0000000011fde5be000000000000803f0000000011fde53e0000000007b8643f
			trafoOSToWSPos=vec3:-43824.2109 240.022049 -3729.67432
			vobName=string:
			visual=string:
			showVisual=bool:0
			visualCamAlign=enum:0
			cdStatic=bool:0
			cdDyn=bool:0
			staticVob=bool:0
			dynShadow=enum:0
			[visual % 0 0]
			[]
			[ai % 0 0]
			[]
			lightPresetInUse=string:FIRE
			lightType=enum:0
			range=float:800
			color=color:240 120 0 255
			spotConeAngle=float:0
			lightStatic=bool:1
			lightQuality=enum:1
			lensflareFX=string:ZSUN_FLARE
		[]

image

Need clear lensflareFX=string:ZSUN_FLARE

@szapp
Copy link
Collaborator

szapp commented Apr 2, 2021

@N1kX94 awesome thanks!

@szapp szapp added compatibility: easy This issue is easy to make compatible. provided fix This issue has a fix provided in the comments. impl: change obj var This issue requires changing properties of objects. type: revert on save The fix for this issue impacts the game and should be reverted when saving. labels Apr 2, 2021
@szapp
Copy link
Collaborator

szapp commented Apr 2, 2021

Similar to #52 #127 #180 #212 #213 (to name a few).

@szapp szapp added this to VOB property in Fix templates Apr 2, 2021
@szapp szapp removed the type: revert on save The fix for this issue impacts the game and should be reverted when saving. label Apr 2, 2021
@AmProsius AmProsius self-assigned this Apr 18, 2021
@AmProsius AmProsius added this to the v1.2.0 milestone Apr 18, 2021
@AmProsius AmProsius added this to To Do in v1.2.0 via automation Apr 18, 2021
@szapp
Copy link
Collaborator

szapp commented May 13, 2021

Note: Along with G1CP_FindVobByPosF, the function Hlp_Is_zCVobLight will come in handy.

@AmProsius AmProsius moved this from To Do to In Progress in v1.2.0 Aug 10, 2021
@AmProsius AmProsius moved this from In Progress to To Do in v1.2.0 Aug 10, 2021
@pawbuj1981
Copy link

H!i what about the future of the project . There is no improvement since last 3 weeks. Is there a chance to have next version till the end of this year ?

@AmProsius
Copy link
Owner Author

H!i what about the future of the project . There is no improvement since last 3 weeks. Is there a chance to have next version till the end of this year ?

The next version will be ready before the end of the year. Since I'm working all alone on this project right now, progress is much slower than before. Also there are things in my life that are more important right now, but I will get back at this patch asap. It really comes from the heart.

@AmProsius AmProsius moved this from To Do to In Progress in v1.2.0 Sep 11, 2021
@AmProsius AmProsius marked this pull request as draft September 13, 2021 18:09
@AmProsius AmProsius assigned szapp and unassigned AmProsius Oct 11, 2021
@AmProsius AmProsius removed this from In Progress in v1.2.0 Oct 30, 2021
@AmProsius AmProsius added this to In Progress in v1.3.0 via automation Oct 30, 2021
@AmProsius AmProsius removed this from In Progress in v1.3.0 Oct 30, 2021
@AmProsius AmProsius added this to In Progress in v1.2.0 via automation Oct 30, 2021
@AmProsius AmProsius removed this from In Progress in v1.2.0 Oct 30, 2021
@AmProsius AmProsius added this to In Progress in v1.3.0 via automation Oct 30, 2021
@AmProsius AmProsius modified the milestones: v1.2.0, v1.3.0 Oct 30, 2021
@szapp szapp removed their assignment Jan 18, 2022
@szapp szapp marked this pull request as ready for review January 18, 2022 22:01
@szapp
Copy link
Collaborator

szapp commented Jan 18, 2022

@AmProsius If you want to have a look; this PR should be ready.

@szapp
Copy link
Collaborator

szapp commented Jan 19, 2022

What I haven't tested: Is the lens flare still in the game save when removing the patch.

@AmProsius AmProsius merged commit 39e0509 into master Jan 27, 2022
@AmProsius AmProsius deleted the bug116 branch January 27, 2022 19:39
v1.3.0 automation moved this from In Progress to Done Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility: easy This issue is easy to make compatible. impl: change obj var This issue requires changing properties of objects. provided fix This issue has a fix provided in the comments. type: world bug This issue requires editing properties of objects in the game world. validation: validated This issue is still present even with Systempack/Union.
Projects
Fix templates
Change VOB property
v1.3.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants