Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cavalorn WPs for his routine are reversed #122

Closed
i5sue5 opened this issue Feb 14, 2021 · 1 comment · Fixed by #161
Closed

Cavalorn WPs for his routine are reversed #122

i5sue5 opened this issue Feb 14, 2021 · 1 comment · Fixed by #161
Labels
compatibility: easy This issue is easy to make compatible. impl: modify/analyze script func This issue requires analyzing and/or modifying the bytecode of script functions. provided fix This issue has a fix provided in the comments. type: session fix The fix for this issues is persistent across a session. validation: validated This issue is still present even with Systempack/Union.
Milestone

Comments

@i5sue5
Copy link

i5sue5 commented Feb 14, 2021

Describe the bug
The WPs for the routine of Cavalorn are reversed. He stands in his hut all day and goes to the outside at night.

Expected behavior
Cavalron now correctly sleeps in his hut at night and stands outside at daytime.

@szapp
Copy link
Collaborator

szapp commented Feb 16, 2021

FUNC VOID Rtn_start_336 ()
{
TA_Sleep (23,00,06,30,"OW_CAVALORN_01");
TA_StandAround (06,30,23,00,"OW_SAWHUT_SLEEP_01");
};

changed to

FUNC VOID Rtn_start_336 () 
 { 
     TA_Sleep        (23,00,06,30,"OW_SAWHUT_SLEEP_01"); 
     TA_StandAround  (06,30,23,00,"OW_CAVALORN_01"); 
 }; 

@szapp szapp added compatibility: easy This issue is easy to make compatible. provided fix This issue has a fix provided in the comments. type: session fix The fix for this issues is persistent across a session. labels Feb 16, 2021
@AmProsius AmProsius added the validation: validated This issue is still present even with Systempack/Union. label Feb 20, 2021
@AmProsius AmProsius added this to To Do in v1.0.0 via automation Feb 21, 2021
@AmProsius AmProsius added this to the v1.0.0 milestone Feb 21, 2021
@AmProsius AmProsius added this to To Do in v1.1.0 Feb 24, 2021
@AmProsius AmProsius removed this from To Do in v1.1.0 Feb 24, 2021
szapp added a commit that referenced this issue Feb 27, 2021
@szapp szapp moved this from To Do to In Progress in v1.0.0 Feb 27, 2021
v1.0.0 automation moved this from In Progress to Done Mar 3, 2021
AmProsius added a commit that referenced this issue Mar 3, 2021
#122: Fix Cavalorn's daily routine
@szapp szapp added this to NPC properties in Fix templates Mar 15, 2021
@szapp szapp moved this from NPC properties to Rewrite Daedalus function in Fix templates Mar 15, 2021
@szapp szapp added the impl: modify/analyze script func This issue requires analyzing and/or modifying the bytecode of script functions. label Mar 16, 2021
@szapp szapp moved this from Rewrite Daedalus function to Unsorted in Fix templates Mar 16, 2021
@szapp szapp added impl: replace assign/push str This issue requires replacing pushed strings or string assignments in the scripts. and removed impl: replace assign/push str This issue requires replacing pushed strings or string assignments in the scripts. labels Mar 17, 2021
@szapp szapp moved this from Unsorted to Other in Fix templates Mar 17, 2021
szapp added a commit that referenced this issue Mar 17, 2021
@szapp szapp moved this from Other to NPC daily routine in Fix templates Mar 31, 2021
szapp added a commit that referenced this issue Apr 20, 2021
@AmProsius AmProsius moved this from NPC daily routine to Modify daily routine in Fix templates Feb 4, 2022
szapp added a commit that referenced this issue Feb 5, 2022
szapp added a commit that referenced this issue Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility: easy This issue is easy to make compatible. impl: modify/analyze script func This issue requires analyzing and/or modifying the bytecode of script functions. provided fix This issue has a fix provided in the comments. type: session fix The fix for this issues is persistent across a session. validation: validated This issue is still present even with Systempack/Union.
Projects
Fix templates
Modify daily routine
v1.0.0
  
Done
Development

Successfully merging a pull request may close this issue.

3 participants