Gate guard doesn't close castle gate in chapter 4

[i5sue5]

Describe the bug
Grd_280_Gardist has ID 230 instead of 280. Therefore he uses the routines of another NPC and the inner gate of the OC stays open in chapter IV.

Expected behavior
Gate guard of the castle now has the correct routine and stands at the gate.

[AmProsius]

Possibly

gothic-1-community-patch/scriptbase/_work/Data/Scripts/Content/Story/NPC/GRD_280_Gardist.d

Lines 5 to 11 in 2775fbc

	name = NAME_Gardist;
	npctype = npctype_guard;
	flags = NPC_FLAG_IMMORTAL; // weil Windenwache !!! wird in Kapitel 4 gelöscht!
	guild = GIL_GRD;
	level = 20;
	voice = 6;
	id = 230;

changed to

    name        =   NAME_Gardist;
    npctype     =   npctype_guard;
    flags       =   NPC_FLAG_IMMORTAL;  // weil Windenwache !!! wird in Kapitel 4 gelöscht!
    guild       =   GIL_GRD;
    level       =   20;
    voice       =   6;
    id          =   280;

[szapp]

This fix might be a bit tricky, because it both relies on a game-save fix (if the NPC is already in the world) and a session-fix (if the NPC is yet to be spawned). Splitting a fix like this is currently not easily supported by our current script setup. I will have a look how to implement it.

[szapp]

Scratch that. It would in fact be an issue if the NPC was created during a running game. This particular NPC is only created once at new game. As game-save fixes are applied after the new game started, they will suffice. No session-fix necessary here.

[szapp]

Gate guard now correctly closes the inner gate of the Old Camp in chapter 4.

Just out of curiosity: Which one is the inner gate? Is that the castle gate?

[AmProsius]

Which one is the inner gate? Is that the castle gate?

If I'm not mistaken the inner gate is the castle gate, right.

[szapp]

I noticed that changing the NPC's ID does in fact correct the daily routine (the NPC now stands beside the gate wheel). Nevertheless, the gate is not closing, even when manually turning the wheel. It looks to me that the wheel is not triggering the gate.

[szapp]

Here are screenshots for the gate EVT_OC_INNERMAINGATE (first image) and the switch EVT_OC_INNERMAINGATE_SWITCH (second image) from the spacer. Within the spacer, triggering the switch closes the gate. So, the problem must be somewhere else. I am aware that switches break during saving and loading, but in a fresh new game the main gate of the Old Camp can be closed and opened while the castle gate remains stuck.

[szapp]

Here the properties of the main gate of the Old camp and the corresponding switch (for comparison).

[szapp]

I will continue about the gate in a separate issue.

[szapp]

This fix can be implemented much easier and as a session fix. The property C_Npc.id is not loaded from the gamesave as previously assumed. Half the implemented fix suffices (and can be simplified).

[szapp]

@AmProsius can you pull branch bug124 run the test and confirm? Then we can merge it and delete it again.

[AmProsius]

Confirmed. I will close this issue then.