Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Butcher is described as two-handed sword #125

Closed
i5sue5 opened this issue Feb 14, 2021 · 2 comments · Fixed by #156
Closed

The Butcher is described as two-handed sword #125

i5sue5 opened this issue Feb 14, 2021 · 2 comments · Fixed by #156
Labels
compatibility: easy This issue is easy to make compatible. impl: replace assign/push str This issue requires replacing pushed strings or string assignments in the scripts. provided fix This issue has a fix provided in the comments. type: session fix The fix for this issues is persistent across a session. validation: validated This issue is still present even with Systempack/Union.
Projects
v1.0.0 Fix templates
Milestone
v1.0.0

Comments

@i5sue5
Copy link

i5sue5 commented Feb 14, 2021 •
edited by AmProsius

Describe the bug
The sword Butcher is described as a two-handed sword in the inventory.

Expected behavior
The sword Butcher is now correctly described as a one-handed sword.

Additional context

  • German sword name: Schlachter
  • Instance ItMw_1H_Sword_Bastard_02
@AmProsius
Copy link
Owner

Possibly

gothic-1-community-patch/scriptbase/_work/Data/Scripts/Content/Items/Melee_Weapons.d

Lines 1404 to 1408 in 2775fbc

description = name;
TEXT[2] = NAME_Damage; COUNT[2] = damageTotal;
TEXT[3] = NAME_Str_needed; COUNT[3] = cond_value[2];
TEXT[4] = NAME_TwoHanded;
TEXT[5] = NAME_Value; COUNT[5] = value;

changed to

    description         = name;
    TEXT[2]             = NAME_Damage;                  COUNT[2]    = damageTotal;
    TEXT[3]             = NAME_Str_needed;              COUNT[3]    = cond_value[2];
    TEXT[4]             = NAME_OneHanded;
    TEXT[5]             = NAME_Value;                   COUNT[5]    = value;

@AmProsius AmProsius added the provided fix This issue has a fix provided in the comments. label Feb 16, 2021
@AmProsius AmProsius changed the title ItMw_1H_Sword_Bastard_02 is described as Two-handed sword The Butcher is described as two-handed sword Feb 16, 2021
@szapp
Copy link
Collaborator

szapp commented Feb 16, 2021

Similar to #41 #44 #49.

@szapp szapp added compatibility: easy This issue is easy to make compatible. type: session fix The fix for this issues is persistent across a session. labels Feb 16, 2021
@AmProsius AmProsius added the validation: validated This issue is still present even with Systempack/Union. label Feb 20, 2021
@AmProsius AmProsius added this to To Do in v1.0.0 via automation Feb 21, 2021
@AmProsius AmProsius added this to the v1.0.0 milestone Feb 21, 2021
@AmProsius AmProsius added this to To Do in v1.1.0 Feb 24, 2021
@AmProsius AmProsius removed this from To Do in v1.1.0 Feb 24, 2021
@szapp szapp moved this from To Do to In Progress in v1.0.0 Feb 27, 2021
szapp added a commit that referenced this issue Feb 27, 2021
@szapp
#125: Fix item text of butcher sword
0b6ccc2
szapp added a commit that referenced this issue Feb 27, 2021
@szapp
Fix typo in changelog regarding #125
40c4ad4
@szapp szapp mentioned this issue Feb 27, 2021
Merged
@AmProsius AmProsius added this to Item property in Fix templates Mar 1, 2021
v1.0.0 automation moved this from In Progress to Done Mar 1, 2021
@AmProsius AmProsius reopened this Mar 1, 2021
v1.0.0 automation moved this from Done to In Progress Mar 1, 2021
v1.0.0 automation moved this from In Progress to Done Mar 3, 2021
AmProsius added a commit that referenced this issue Mar 3, 2021
@AmProsius
Merge pull request #156 from AmProsius/bug125
80a164b 
#125: Fix item text of butcher sword
szapp added a commit that referenced this issue Mar 13, 2021
@szapp
Simplify #12 #28 #44 #125 with GetIntVar
6721b44
@szapp szapp added impl: modify/analyze script func This issue requires analyzing and/or modifying the bytecode of script functions. impl: replace assign/push str This issue requires replacing pushed strings or string assignments in the scripts. and removed impl: modify/analyze script func This issue requires analyzing and/or modifying the bytecode of script functions. labels Mar 17, 2021
This was referenced Mar 19, 2021
Closed
Merged
AmProsius added a commit that referenced this issue Mar 25, 2021
@AmProsius
fix: correct comment of fix #125
4c4ad20
szapp added a commit that referenced this issue Apr 20, 2021
@szapp
refactor: simplify test of #125
de2ea33
@szapp szapp mentioned this issue Jan 7, 2022
Closed
This was referenced Jan 13, 2022
Closed
Closed
Closed
@szapp szapp moved this from Instance variable (string) to Item instance variable (string) in Fix templates Feb 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compatibility: easy This issue is easy to make compatible. impl: replace assign/push str This issue requires replacing pushed strings or string assignments in the scripts. provided fix This issue has a fix provided in the comments. type: session fix The fix for this issues is persistent across a session. validation: validated This issue is still present even with Systempack/Union.
Projects
Fix templates
Change item instance variable (string)
v1.0.0
  
Done
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

#125: Fix item text of butcher sword AmProsius/gothic-1-community-patch
3 participants
@AmProsius @i5sue5 @szapp