Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The trading menu is opened after Sharky is appointed as new fence #126

Closed
i5sue5 opened this issue Feb 14, 2021 · 2 comments · Fixed by #154
Closed

The trading menu is opened after Sharky is appointed as new fence #126

i5sue5 opened this issue Feb 14, 2021 · 2 comments · Fixed by #154
Labels
compatibility: easy This issue is easy to make compatible. impl: replace assign int This issue requires replacing integer assignments in the scripts. provided fix This issue has a fix provided in the comments. type: session fix The fix for this issues is persistent across a session.
Projects
v1.0.0 Fix templates
Milestone
v1.0.0

Comments

@i5sue5
Copy link

i5sue5 commented Feb 14, 2021 •
edited by AmProsius

Describe the bug
The dialogue option of Sharky for Fisk's quest opens the trading menu.

Expected behavior
Sharky's dialog option for Fisk's quest "New Fence for Fisk" no longer opens the trading menu.

Additional context

  • German quest name: Neuer Hehler für Fisk
  • Instance ORG_843_Sharky_Fisk
@AmProsius
Copy link
Owner

AmProsius commented Feb 16, 2021 •
edited

Possibly

gothic-1-community-patch/scriptbase/_work/Data/Scripts/Content/Story/Missions/DIA_ORG_843_Sharky.d

Lines 28 to 37 in 2775fbc

instance Org_843_Sharky_Fisk (C_INFO)
{
npc = Org_843_Sharky;
nr = 2;
condition = Org_843_Sharky_Fisk_Condition;
information = Org_843_Sharky_Fisk_Info;
permanent = 0;
description = "Fisk from the Old Camp is looking for a new trading partner.";
trade = 1;
};

changed to

instance  Org_843_Sharky_Fisk (C_INFO)
{
    npc             = Org_843_Sharky;
    nr              = 2;
    condition       = Org_843_Sharky_Fisk_Condition;
    information     = Org_843_Sharky_Fisk_Info;
    permanent       = 0;
    description     = "Fisk from the Old Camp is looking for a new trading partner.";
};

@AmProsius AmProsius added the provided fix This issue has a fix provided in the comments. label Feb 16, 2021
@szapp
Copy link
Collaborator

szapp commented Feb 16, 2021

Similar to #30.

@szapp szapp added compatibility: easy This issue is easy to make compatible. type: session fix The fix for this issues is persistent across a session. labels Feb 16, 2021
@AmProsius AmProsius changed the title The info ORG_843_Sharky_Fisk opens the trading menu The trading menu is opened after Sharky is appointed as new fence Feb 16, 2021
@AmProsius AmProsius added the validation: required This issue needs validation from one of the validators. label Feb 20, 2021
@AmProsius AmProsius added this to To Do in v1.0.0 via automation Feb 21, 2021
@AmProsius AmProsius added this to the v1.0.0 milestone Feb 21, 2021
@AmProsius AmProsius added this to To Do in v1.1.0 Feb 24, 2021
@AmProsius AmProsius removed this from To Do in v1.1.0 Feb 24, 2021
@szapp szapp moved this from To Do to In Progress in v1.0.0 Feb 27, 2021
szapp added a commit that referenced this issue Feb 27, 2021
@szapp
#126: Remove trade menu during Shark's quest dialog
73c825c
@szapp szapp mentioned this issue Feb 27, 2021
Merged
@AmProsius AmProsius added this to Item property (int) in Fix templates Mar 1, 2021
v1.0.0 automation moved this from In Progress to Done Mar 3, 2021
AmProsius added a commit that referenced this issue Mar 3, 2021
@AmProsius
Merge pull request #154 from AmProsius/bug126
ef82a73 
#126: Remove trade menu during Shark's quest dialog
@szapp szapp added impl: modify/analyze script func This issue requires analyzing and/or modifying the bytecode of script functions. impl: replace assign int This issue requires replacing integer assignments in the scripts. and removed impl: modify/analyze script func This issue requires analyzing and/or modifying the bytecode of script functions. labels Mar 17, 2021
szapp added a commit that referenced this issue Apr 20, 2021
@szapp
refactor: simplify test of #126
681fa7b
szapp added a commit that referenced this issue Apr 20, 2021
@szapp
refactor: make test of #126 automatic
781a03a
@szapp szapp removed the validation: required This issue needs validation from one of the validators. label May 14, 2021
@szapp szapp moved this from Instance variable (int) to Info instance variable (int) in Fix templates Feb 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compatibility: easy This issue is easy to make compatible. impl: replace assign int This issue requires replacing integer assignments in the scripts. provided fix This issue has a fix provided in the comments. type: session fix The fix for this issues is persistent across a session.
Projects
Fix templates
Change info instance variable (int)
v1.0.0
  
Done
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

#126: Remove trade menu during Shark's quest dialog AmProsius/gothic-1-community-patch
3 participants
@AmProsius @i5sue5 @szapp