New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
One chest in NC cannot be opened #127
Conversation
changed to
|
I suggest to
With these checks it should be confirmed that it is the correct chest and that the problem was not somehow fixed already. Then it is just about setting the properties. On reverting, do essentially the same, but precede the checks with a check whether the G1CP fix was even applied (see other revertible fixes). @AmProsius Do you think these kinds of hints are helpful and enough for you to write the fix? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't run this test, but the code looks really good. I have a suggestion for improving the test (see comment below).
Finding VOBs by their exact position can now be further narrowed down by their class. Like before only the first matching VOB will be found. The function can now also detect light VOBs which where previously ignored. For details, see the header commment of ent of 'G1CP_FindVobByPosPtr'. Common class definitions are defined as constants in constants.d. All affected fixes are updated. Refs #46 #51 #52 #127 #212 #213 #226
Instead of specifying a class to narrow down the search (see previous commit), the option is now more versatile: Now the last parameter is a callback function. It can either be one of the existing class check functions or a custom function to narrow down the search more flexibly and potentially based on more or more complex checks. Refs #46 #51 #52 #127 #212 #213 #226
Describe the bug
Right next to the house of Buster there is a chest that cannot be opened/picked.
Expected behavior
The closed chest next to Buster's house can now be picked.
Additional context