New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Guard has duplicated END dialog #128
Conversation
Similar to #42. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's quite elegant to piggyback #42!
However, the fix status of #42 will mark as failed if the two dialogs in #42 are in fact fixed but the one from #128 is not. Same for the opposite. That is highly misleading and could cause a lot of headaches during testing.
I propose to rather copy and adjust the function G1CP_042_GuardExitDialog
while re-using the function G1CP_042_ConfirmByteCode
(no need to copy that one).
Wouldn't it be even better then to split the original #42 in two separate fixes as well? |
Yes, I agree. This would allow for best inspection during testing. But I fear that it would convolute the fix list / changelog, with many identical entries. An alternative is to collect all of them in one fix, as done in #42 so far. Both options have their pros and cons, I will leave this decision up to you. |
Thanks for taking care of it. There are a few things that may not work with the new changes. I don't have the time to get into it right now, but hold out before merging this PR. |
Describe the bug
The guard right next to Glen in the old mine has two ending dialogue options.
Expected behavior
There should be just one option to end the dialogue.
Additional context
Instance
Grd_264_Gardist
.