The player can cancel fights by entering a room

[szapp]

Describe the bug
The player can run into a room and immediately leave it to cancel a fight if the NPC has full HP.

Expected behavior
The player can no longer cancel fights by entering and leaving a room.

[AmProsius]

gothic-1-community-patch/scriptbase/_work/Data/Scripts/Content/AI/ZS_Human/ZS_Attack.d

Lines 279 to 295 in 2775fbc

	func void B_CombatAssessEnterRoom ()
	{
	PrintDebugNpc (PD_ZS_FRAME, "B_CombatAssessEnterRoom");
	if (Wld_GetPlayerPortalGuild() == GIL_NONE
	&& !Npc_HasNews(self, NEWS_THEFT, other, self))
	{
	PrintDebugNpc (PD_ZS_CHECK, "...SC hat Raum des NSCs verlassen und noch nichts geklaut!");
	if (self.attribute[ATR_HITPOINTS]==self.attribute[ATR_HITPOINTS_MAX]) // ...und wurde der NSC noch nicht getroffen...
	{
	PrintDebugNpc (PD_ZS_CHECK, "...NSC unverletzt!");
	B_FullStop (self);
	B_ResetTempAttitude (self);
	B_AssessRemoveWeapon(); // ...dann bricht der NSC den Kampf gerade noch ab!
	};
	};
	};

changed to

func void B_CombatAssessEnterRoom ()
{
	PrintDebugNpc				(PD_ZS_FRAME, "B_CombatAssessEnterRoom");
	if (Wld_GetPlayerPortalGuild() == GIL_NONE
	&&	!Npc_HasNews(self, NEWS_THEFT, other, self)
	&& 	self.aivar[AIV_ATTACKREASON] == AIV_AR_INTRUDER ) // sonst braucht man nur in einen Raum rennen und der Kampf ist vorbei
	{
		PrintDebugNpc			(PD_ZS_CHECK,	"...SC hat Raum des NSCs verlassen und noch nichts geklaut!");

		if (self.attribute[ATR_HITPOINTS]==self.attribute[ATR_HITPOINTS_MAX])				// ...und wurde der NSC noch nicht getroffen...
		{
			PrintDebugNpc		(PD_ZS_CHECK,	"...NSC unverletzt!");
			B_FullStop			(self);
			B_SetAttackReason	(self,	AIV_AR_NONE);
			B_ResetTempAttitude	(self);	
			B_AssessRemoveWeapon();															// ...dann bricht der NSC den Kampf gerade noch ab!
		};
	};
};

[szapp]

This fix could be implemented by hooking B_CombatAssessEnterRoom and return prematurely, if self.aivar[AIV_ATTACKREASON] != AIV_AR_INTRUDER. Otherwise call the original function.

[AmProsius]

This fix could be implemented by hooking B_CombatAssessEnterRoom and return prematurely, if self.aivar[AIV_ATTACKREASON] != AIV_AR_INTRUDER. Otherwise call the original function.

What's with B_SetAttackReason(self, AIV_AR_NONE); then? Is it not needed anymore or did you overlook that?

[szapp]

I can't reproduce the bug. @AmProsius can you give me a scenario how to trigger it reliably?

[szapp]

Actually, the fix as proposed here does not work. (Where does it come from?) An attack reason (AIV_ATTACKREASON) of AIV_AR_INTRUDER is only used for actual intruders, that is, when the PC runs into the castle or other guild-restricted areas. It is unrelated to portals (= private huts).

All this suggested change does is completely disabling aborting an attack when the PC leaves a hut, because the condition will never be true. That's unfortunately not a fix, it actually removes a feature.

[szapp]

I found a solution that should work:

gothic-1-community-patch/scriptbase/_work/Data/Scripts/Content/AI/ZS_Human/ZS_Attack.d

Lines 279 to 295 in 2775fbc

	func void B_CombatAssessEnterRoom ()
	{
	PrintDebugNpc (PD_ZS_FRAME, "B_CombatAssessEnterRoom");
	if (Wld_GetPlayerPortalGuild() == GIL_NONE
	&& !Npc_HasNews(self, NEWS_THEFT, other, self))
	{
	PrintDebugNpc (PD_ZS_CHECK, "...SC hat Raum des NSCs verlassen und noch nichts geklaut!");
	if (self.attribute[ATR_HITPOINTS]==self.attribute[ATR_HITPOINTS_MAX]) // ...und wurde der NSC noch nicht getroffen...
	{
	PrintDebugNpc (PD_ZS_CHECK, "...NSC unverletzt!");
	B_FullStop (self);
	B_ResetTempAttitude (self);
	B_AssessRemoveWeapon(); // ...dann bricht der NSC den Kampf gerade noch ab!
	};
	};
	};

changed to

 func void B_CombatAssessEnterRoom () 
 { 
     PrintDebugNpc               (PD_ZS_FRAME, "B_CombatAssessEnterRoom"); 
     if (Wld_GetPlayerPortalGuild() == GIL_NONE 
     &&  !Npc_HasNews(self, NEWS_THEFT, other, self))
     &&  ((Npc_WasInState(self, ZS_ClearRoom)) || (Npc_WasInState(self, ZS_ClearRoomWait)))
     { 
         PrintDebugNpc           (PD_ZS_CHECK,   "...SC hat Raum des NSCs verlassen und noch nichts geklaut!"); 
  
         if (self.attribute[ATR_HITPOINTS]==self.attribute[ATR_HITPOINTS_MAX])               // ...und wurde der NSC noch nicht getroffen... 
         { 
             PrintDebugNpc       (PD_ZS_CHECK,   "...NSC unverletzt!"); 
             B_FullStop          (self); 
             B_ResetTempAttitude (self); 
             B_AssessRemoveWeapon();                                                         // ...dann bricht der NSC den Kampf gerade noch ab! 
         }; 
     }; 
 };

[szapp]

The test is manual:

• Cause a fight with an NPC (without causing them damage!) and enter and leave the nearby room: The NPC will continue the fight.
• Enter a room and wait for an NPC to react and attack the PC. Leave the room (without causing them damage!). The NPC will stop the fight.

[AmProsius]

@AmProsius can you give me a scenario how to trigger it reliably?

I reproduced the bug by attacking the immortal gate guard at the main gate of the Old Camp and then running into and out of a hut. The guard then stopped attacking me and returned to the gate.