Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Horatio may lower STRENGTH #15

Closed
AmProsius opened this issue Dec 30, 2020 · 1 comment · Fixed by #64
Closed

Horatio may lower STRENGTH #15

AmProsius opened this issue Dec 30, 2020 · 1 comment · Fixed by #64
Labels
impl: replace func call This issue requires replacing function calls in the scripts. provided fix This issue has a fix provided in the comments. type: session fix The fix for this issues is persistent across a session. validation: validated This issue is still present even with Systempack/Union.
Milestone

Comments

@AmProsius
Copy link
Owner

AmProsius commented Dec 30, 2020

Describe the bug
The player loses Strength to a maximum of 100 as part of the quest "Horatio the Peasant" if he had more than 100 Strength.

Expected behavior
The player doesn't lose Strength as part of the quest "Horatio the Peasant" if he had more than 100 Strength.

@AmProsius AmProsius added this to To Do in v1.0.0 Dec 30, 2020
@AmProsius AmProsius removed ai labels Jan 1, 2021
@catalinstoian
Copy link

catalinstoian commented Jan 9, 2021

func void DIA_Horatio_HelpSTR_LEARN_NOW()
{
if (other.attribute[ATR_STRENGTH]<=(100-5))
{
other.attribute[ATR_STRENGTH] = other.attribute[ATR_STRENGTH] + 5;
PrintScreen ("Strength + 5", -1,-1,"FONT_OLD_20_WHITE.TGA",2);
}
else
{
other.attribute[ATR_STRENGTH] = 100;
PrintScreen ("Strength: 100", -1,-1,"FONT_OLD_20_WHITE.TGA",2);
};
AI_Output (self, other,"DIA_Horatio_HelpSTR_LEARN_NOW_09_00"); //If you want to hit powerfully, you need to know the right tactics. That's the first thing you learn as a smith.
AI_Output (self, other,"DIA_Horatio_HelpSTR_LEARN_NOW_09_01"); //Learn to push your whole arm through, from the shoulder down to the wrist.
AI_Output (self, other,"DIA_Horatio_HelpSTR_LEARN_NOW_09_02"); //The better you get at that, the more powerful the blow. You'll get the hang of it pretty quick.
};

changed to

func void DIA_Horatio_HelpSTR_LEARN_NOW()
{
    if (other.attribute[ATR_STRENGTH]<=(100-5))
    {
        other.attribute[ATR_STRENGTH] = other.attribute[ATR_STRENGTH] + 5;
        PrintScreen ("Strength + 5", -1,-1,"FONT_OLD_20_WHITE.TGA",2);
    }
    else if (other.attribute[ATR_STRENGTH]>100)
    {
        PrintScreen ("No increase over maximum 100!", -1,-1,"FONT_OLD_20_WHITE.TGA",2);
    }
    else
    {
        other.attribute[ATR_STRENGTH] = 100;
        PrintScreen ("Strength: 100", -1,-1,"FONT_OLD_20_WHITE.TGA",2);
    };

    AI_Output (self, other,"DIA_Horatio_HelpSTR_LEARN_NOW_09_00"); //If you want to hit powerfully, you need to know the right tactics. That's the first thing you learn as a smith.
    AI_Output (self, other,"DIA_Horatio_HelpSTR_LEARN_NOW_09_01"); //Learn to push your whole arm through, from the shoulder down to the wrist.
    AI_Output (self, other,"DIA_Horatio_HelpSTR_LEARN_NOW_09_02"); //The better you get at that, the more powerful the blow. You'll get the hang of it pretty quick.
};

@AmProsius AmProsius added type: session fix The fix for this issues is persistent across a session. and removed validation required labels Jan 16, 2021
@AmProsius AmProsius linked a pull request Jan 17, 2021 that will close this issue
v1.0.0 automation moved this from To Do to Done Jan 17, 2021
AmProsius added a commit that referenced this issue Jan 17, 2021
#15 fix strengh decrease in Horatio's dialog
szapp added a commit that referenced this issue Jan 28, 2021
@AmProsius AmProsius added this to the v1.0.0 milestone Feb 13, 2021
@AmProsius AmProsius added provided fix This issue has a fix provided in the comments. validation: validated This issue is still present even with Systempack/Union. labels Mar 13, 2021
szapp added a commit that referenced this issue Mar 13, 2021
No longer the external is hooked but its call intercepted
@szapp szapp added this to Unsorted in Fix templates Mar 15, 2021
@szapp szapp moved this from Unsorted to Replace calls to external functions in Fix templates Mar 15, 2021
@szapp szapp added the impl: replace func call This issue requires replacing function calls in the scripts. label Mar 16, 2021
@szapp szapp moved this from Replace function calls to Unsorted in Fix templates Mar 16, 2021
@szapp szapp moved this from Unsorted to NPC function in Fix templates Mar 17, 2021
@szapp szapp moved this from NPC function to Dialog: Info function in Fix templates Mar 17, 2021
szapp added a commit that referenced this issue Mar 21, 2021
AmProsius added a commit that referenced this issue Apr 12, 2021
@szapp szapp moved this from Modify dialog function to Extend dialog function in Fix templates Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impl: replace func call This issue requires replacing function calls in the scripts. provided fix This issue has a fix provided in the comments. type: session fix The fix for this issues is persistent across a session. validation: validated This issue is still present even with Systempack/Union.
Projects
Fix templates
Extend dialog function
v1.0.0
  
Done
Development

Successfully merging a pull request may close this issue.

3 participants