Spelling - Ring of Fire Protection (EN) #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AmProsius
added
language dependent
|
changed to description = "Ring of Fire Protection"; |
AmProsius
added
opinionated
AmProsius
added
compatibility: easy
szapp
added
the
impl: replace assign/push str
szapp
approved these changes
Apr 2, 2021
| @@ -6,6 +6,7 @@ | |||
| * Fix [#50](https://g1cp.org/issues/50): The inaccessible chest of the crypt below the stonehenge is now correctly positioned and accessible. | |||
| * Fix [#52](https://g1cp.org/issues/52): The grindstone in the New Camp now correctly requires a sword blade to use. | |||
| * Fix [#149](https://g1cp.org/issues/149): The armor "Improved ore Armor" is now correctly labelled as "Improved Ore Armor". | |||
| * Fix [#152](https://g1cp.org/issues/152): The description of the ring "Protection of Fire" is corrected to "Ring of Fire Protection". | |||
| var int symbId; symbId = MEM_GetSymbolIndex("Schutzring_Feuer2"); | ||
| const string needle = "Protection of Fire"; | ||
| const string replace = "Ring of Fire Protection"; | ||
| return (G1CP_ReplaceAssignStr(symbId, "C_ITEM.DESCRIPTION", 0, needle, replace) > 0); |
There was a problem hiding this comment.
I have split this line to stay within 120 character limit of the line.
| if (Hlp_StrCmp(item.description, "Ring of Fire Protection")) { | ||
| return TRUE; | ||
| } else { | ||
| var string msg; msg = "Description incorrect: description = '"; |
There was a problem hiding this comment.
I set "description" to upper case for consistent test output.
szapp
added a commit
that referenced
this pull request
Apr 19, 2021
szapp
moved this from Instance variable (string)
to Item instance variable (string)
in Fix templates
AmProsius
moved this from Change item instance variable (string)
to Change item instance description
in Fix templates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the bug
In the English localization the description of the ring Protection of Fire is inconsistent and grammatically incorrect.
Changelog
Changed description of ring "Protection of Fire" to "Ring of Fire Protection"