Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Potion of Velocity has wrong ore value #157

Closed
szapp opened this issue Feb 27, 2021 · 1 comment · Fixed by #159
Closed

Potion of Velocity has wrong ore value #157

szapp opened this issue Feb 27, 2021 · 1 comment · Fixed by #159
Labels
compatibility: easy This issue is easy to make compatible. impl: replace assign int This issue requires replacing integer assignments in the scripts. provided fix This issue has a fix provided in the comments. type: session fix The fix for this issues is persistent across a session. validation: validated This issue is still present even with Systempack/Union.
Projects
v1.0.0 Fix templates
Milestone
v1.0.0

Comments

@szapp
Copy link
Collaborator

szapp commented Feb 27, 2021 •
edited

Describe the bug
Potion of Velocity and has the wrong ore value.

Expected behavior
The Potion of Velocity now has the correct ore value.
Do not write the specific ore values here, because the fix takes the ore values possibly modified by a mod.

Additional context
This issue was split from #41. The same bug in the Potion of Haste is addressed in [TBA].

The issues are split to be able to give a proper fix status if the fix succeeds for one but fails for the other of the items.
@szapp szapp added type: session fix The fix for this issues is persistent across a session. compatibility: easy This issue is easy to make compatible. validation: validated This issue is still present even with Systempack/Union. provided fix This issue has a fix provided in the comments. labels Feb 27, 2021
This was referenced Feb 27, 2021
Closed
Closed
@szapp
Copy link
Collaborator Author

szapp commented Feb 27, 2021

gothic-1-community-patch/scriptbase/_work/Data/Scripts/Content/Items/Potions.d

Line 694 in e66b303

value = Value_Haste1;

changed to

value 			=	Value_Haste2;

@szapp szapp added this to the v1.0.0 milestone Feb 27, 2021
@szapp szapp added this to To Do in v1.0.0 via automation Feb 27, 2021
@szapp szapp moved this from To Do to In Progress in v1.0.0 Feb 27, 2021
szapp added a commit that referenced this issue Feb 27, 2021
@szapp
#157: Fix the ore value of the second speed potion
e4f6018
@szapp szapp mentioned this issue Feb 27, 2021
Merged
szapp added a commit that referenced this issue Feb 27, 2021
@szapp
Simplify symbol retrieval in #157
b54b90c
@AmProsius AmProsius added this to Item property in Fix templates Mar 1, 2021
@AmProsius AmProsius moved this from Item property (string) to Item property (int) in Fix templates Mar 1, 2021
v1.0.0 automation moved this from In Progress to Done Mar 3, 2021
AmProsius added a commit that referenced this issue Mar 3, 2021
@AmProsius
Merge pull request #159 from AmProsius/bug157
cccbe85 
#157: Fix the ore value of the second speed potion
@szapp szapp added impl: modify/analyze script func This issue requires analyzing and/or modifying the bytecode of script functions. impl: replace assign int This issue requires replacing integer assignments in the scripts. and removed impl: modify/analyze script func This issue requires analyzing and/or modifying the bytecode of script functions. labels Mar 17, 2021
szapp added a commit that referenced this issue Apr 19, 2021
@szapp
refactor: simplify test of #157
997e913
@szapp szapp moved this from Instance variable (int) to Item instance variable (int) in Fix templates Feb 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compatibility: easy This issue is easy to make compatible. impl: replace assign int This issue requires replacing integer assignments in the scripts. provided fix This issue has a fix provided in the comments. type: session fix The fix for this issues is persistent across a session. validation: validated This issue is still present even with Systempack/Union.
Projects
Fix templates
Change item instance variable (int)
v1.0.0
  
Done
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

#157: Fix the ore value of the second speed potion AmProsius/gothic-1-community-patch
1 participant
@szapp