Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Castle gate of the Old Camp cannot close #163

Closed
szapp opened this issue Feb 27, 2021 · 1 comment · Fixed by #164
Closed

Castle gate of the Old Camp cannot close #163

szapp opened this issue Feb 27, 2021 · 1 comment · Fixed by #164
Labels
compatibility: easy This issue is easy to make compatible. impl: modify engine func This issue requires modifying the machine code of engine functions. type: session fix The fix for this issues is persistent across a session. validation: validated This issue is still present even with Systempack/Union.
Milestone

Comments

@szapp
Copy link
Collaborator

szapp commented Feb 27, 2021

Describe the bug
The castle gate of the Old Camp is blocked and cannot close.

Expected behavior
The castle gate of the Old Camp is no longer blocked and can properly close.

Additional context
The issue arose from a discussion in #124.

  1. Positioning
    The gate is blocked through the wall by the winch (the switch/wheel) that is used to open it. Unfortunately, because of the size and orientation of the bounding boxes the winch has to be moved quite far to avoid collision between the gate and the winch. There are two options:

    1. Either the winch is moved to the opposite wall (see screenshot below)
    2. Or the winch stays where it is and we simply turn off its dynamic collision. That would have the side-effect that the player can walk through it (using it is still possible).
  2. Gate state stored in game save
    Aside from that there is a more pressing issue: The state of the gate is stored in the game save. Once we unblock the gate and it is closed, we will have to revert it to be open on saving the game. The problem here is, that we don't know if the gate was opened during the game due to our fixes (see Gate guard doesn't close castle gate in chapter 4  #124) or by the mod. Therefore, we cannot just revert the gate to open on saving, because that might break the mod. Are there any suggestions how we could tackle that problem?

winch_reposition

@szapp szapp added type: world bug This issue requires editing properties of objects in the game world. type: revert on save The fix for this issue impacts the game and should be reverted when saving. compatibility: difficult This issue is difficult to make compatible. validation: validated This issue is still present even with Systempack/Union. labels Feb 27, 2021
szapp added a commit that referenced this issue Feb 27, 2021
szapp added a commit that referenced this issue Feb 28, 2021
szapp added a commit that referenced this issue Feb 28, 2021
@szapp szapp added compatibility: easy This issue is easy to make compatible. type: session fix The fix for this issues is persistent across a session. and removed compatibility: difficult This issue is difficult to make compatible. type: revert on save The fix for this issue impacts the game and should be reverted when saving. type: world bug This issue requires editing properties of objects in the game world. labels Feb 28, 2021
@AmProsius AmProsius added this to MOB property in Fix templates Mar 3, 2021
@AmProsius AmProsius added this to To Do in v1.0.0 via automation Mar 3, 2021
@AmProsius AmProsius added this to the v1.0.0 milestone Mar 3, 2021
@AmProsius AmProsius moved this from To Do to In Progress in v1.0.0 Mar 3, 2021
v1.0.0 automation moved this from In Progress to Done Mar 3, 2021
AmProsius added a commit that referenced this issue Mar 3, 2021
@szapp szapp removed this from MOB property in Fix templates Mar 14, 2021
@szapp szapp added this to Rewrite engine function in Fix templates Mar 15, 2021
@szapp szapp added the impl: modify engine func This issue requires modifying the machine code of engine functions. label Mar 16, 2021
@szapp szapp moved this from Rewrite engine function to Unsorted in Fix templates Mar 16, 2021
@szapp szapp moved this from Unsorted to Other in Fix templates Mar 17, 2021
szapp added a commit that referenced this issue Apr 19, 2021
@szapp szapp moved this from Other to Engine mechanics in Fix templates Apr 26, 2021
@pawbuj1981
Copy link

There is similar bug/issue with main gate of Old Camp (close to "OC1" waypoint). Once gate is being closed/opened again - it looks like can be opened only for 60-70% (like there is obstacle somewhere close). I have seen it fixed by GMF.
Also you should think about to add sounds for fixed gates (depens if wood/stone, metal etc.).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility: easy This issue is easy to make compatible. impl: modify engine func This issue requires modifying the machine code of engine functions. type: session fix The fix for this issues is persistent across a session. validation: validated This issue is still present even with Systempack/Union.
Projects
Fix templates
Modify engine function
v1.0.0
  
Done
Development

Successfully merging a pull request may close this issue.

3 participants