New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gor Na Bar offers to become a templar to anyone #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AmProsius
added
validation: required
This issue needs validation from one of the validators.
provided fix
This issue has a fix provided in the comments.
labels
Feb 28, 2021
Lines 102 to 109 in 0623f55
changed to FUNC int Tpl_1400_GorNaBar_VICTORY_Condition()
{
if (Npc_HasItems (hero,ItAt_Crawlerqueen ) >= 1)
&& (Npc_GetTrueGuild (hero) == GIL_NOV)
{
return TRUE;
};
}; |
AmProsius
added
opinionated
This issue or this issues' fix is opinionated and not predefined by the scripts.
and removed
opinionated
This issue or this issues' fix is opinionated and not predefined by the scripts.
labels
Mar 1, 2021
szapp
added
compatibility: easy
This issue is easy to make compatible.
impl: hook script func
This issue requires hooking script functions.
type: session fix
The fix for this issues is persistent across a session.
labels
Apr 5, 2021
AmProsius
added
validation: validated
This issue is still present even with Systempack/Union.
and removed
validation: required
This issue needs validation from one of the validators.
labels
Jul 31, 2021
szapp
reviewed
Aug 5, 2021
szapp
approved these changes
Aug 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't run the test, but the code looks good to me.
szapp
moved this from Modify dialog conditions
to Add dialog conditions
in Fix templates
Feb 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
compatibility: easy
This issue is easy to make compatible.
impl: hook script func
This issue requires hooking script functions.
provided fix
This issue has a fix provided in the comments.
type: session fix
The fix for this issues is persistent across a session.
validation: validated
This issue is still present even with Systempack/Union.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the bug
No matter the player's guild, Gor Na Bar tells him to speak to Cor Angar about becoming a templar and a log entry is created.
Expected behavior
Gor Na Bar now tells only novices to speak to Cor Angar about becoming a templar.