Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jackal doesn't recognize the player's camp membership #17

Closed
AmProsius opened this issue Dec 30, 2020 · 1 comment · Fixed by #65
Closed

Jackal doesn't recognize the player's camp membership #17

AmProsius opened this issue Dec 30, 2020 · 1 comment · Fixed by #65
Labels
impl: hook script func This issue requires hooking script functions. type: session fix The fix for this issues is persistent across a session.
Projects
v1.0.0 Fix templates
Milestone
v1.0.0

Comments

@AmProsius
Copy link
Owner

Jackal still harasses the player for protection money after the player has joined a camp.
@catalinstoian
Copy link

catalinstoian commented Jan 9, 2021 •
edited by AmProsius

DIA_GRD_201_Jackal.d

FUNC INT Info_Jackal_Hello_Condition()
{	
	if (Kapitel <= 2) && (Npc_GetTrueGuild(other) == GIL_None)
	{
		return 1;
	};
};

szapp added a commit that referenced this issue Jan 15, 2021
@szapp
#17 add new condition to jackal's dialog
d1c320c
@AmProsius AmProsius added type: session fix The fix for this issues is persistent across a session. and removed validation required labels Jan 16, 2021
@AmProsius AmProsius added this to To Do in v1.0.0 via automation Jan 16, 2021
@AmProsius AmProsius linked a pull request Jan 17, 2021 that will close this issue
#17 add new condition to jackal's dialog #65
Merged
@AmProsius AmProsius moved this from To Do to In Progress in v1.0.0 Jan 17, 2021
v1.0.0 automation moved this from In Progress to Done Jan 17, 2021
AmProsius added a commit that referenced this issue Jan 17, 2021
@AmProsius
Merge pull request #65 from AmProsius/bug017
287a06e 
#17 add new condition to jackal's dialog
@szapp szapp mentioned this issue Jan 18, 2021
Closed
@AmProsius AmProsius added this to the v1.0.0 milestone Feb 13, 2021
@AmProsius AmProsius added this to Info condition in Fix templates Mar 3, 2021
@szapp szapp added the impl: hook script func This issue requires hooking script functions. label Mar 16, 2021
@szapp szapp moved this from Hook Daedalus function to Unsorted in Fix templates Mar 16, 2021
@szapp szapp moved this from Unsorted to Dialog: Info condition in Fix templates Mar 17, 2021
AmProsius added a commit that referenced this issue Apr 13, 2021
@AmProsius
refactor: simplify test of #17
87705e2
AmProsius added a commit that referenced this issue Apr 13, 2021
@AmProsius
fix: add pass checks for tests of #17 and #18
ea31ebb
AmProsius added a commit that referenced this issue Apr 13, 2021
@AmProsius
fix: remove unnecessary comments of tests of #17 and #18
37561f8
@szapp szapp mentioned this issue Apr 21, 2021
Merged
This was referenced Jan 27, 2022
Open
Open
Open
@szapp szapp moved this from Modify dialog conditions to Add dialog conditions in Fix templates Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
impl: hook script func This issue requires hooking script functions. type: session fix The fix for this issues is persistent across a session.
Projects
Fix templates
Add dialog conditions
v1.0.0
  
Done
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

#17 add new condition to jackal's dialog AmProsius/gothic-1-community-patch
3 participants
@AmProsius @catalinstoian @szapp