Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spelling - Rice Lord's Key (EN) #175

Merged
merged 1 commit into from Mar 20, 2021
Merged

Spelling - Rice Lord's Key (EN) #175

merged 1 commit into from Mar 20, 2021

Conversation

szapp
Copy link
Collaborator

@szapp szapp commented Mar 19, 2021

Describe the bug
In the English localization there's a typo in the Rice Lord's Key's name.

Changelog
Changed the name "Rice Lord's Bowl" to "Rice Lord's Key".

Additional context
Looks like the translator made a mistake by translating Schüssel (Bowl) instead of Schlüssel (Key).

@AmProsius AmProsius added the validation: required This issue needs validation from one of the validators. label Mar 5, 2021
@AmProsius
Copy link
Owner Author

gothic-1-community-patch/scriptbase/_work/Data/Scripts/Content/Items/MissionItems_1.d

Line 1119 in 2b5e599

name = "Rice Lord's Bowl";

changed to

name                =   "Rice Lord's Key";

@AmProsius AmProsius added provided fix This issue has a fix provided in the comments. language dependent This issue only occurs in certain localizations. labels Mar 5, 2021
@AmProsius AmProsius added this to To Do in v1.1.0 via automation Mar 5, 2021
@AmProsius AmProsius added this to Instance variable (string) in Fix templates Mar 5, 2021
@AmProsius AmProsius added this to the v1.1.0 milestone Mar 5, 2021
@szapp szapp added impl: modify/analyze script func This issue requires analyzing and/or modifying the bytecode of script functions. impl: replace assign/push str This issue requires replacing pushed strings or string assignments in the scripts. type: session fix The fix for this issues is persistent across a session. and removed impl: modify/analyze script func This issue requires analyzing and/or modifying the bytecode of script functions. labels Mar 17, 2021
@AmProsius AmProsius self-assigned this Mar 19, 2021
@szapp szapp moved this from To Do to In Progress in v1.1.0 Mar 19, 2021
szapp
szapp commented Mar 19, 2021
View reviewed changes
Copy link
Collaborator Author

@szapp szapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because I am the creator of the pull request, I cannot click "approve", but I do.

@szapp szapp added the compatibility: easy This issue is easy to make compatible. label Mar 20, 2021
@AmProsius AmProsius merged commit 395f574 into master Mar 20, 2021
v1.1.0 automation moved this from In Progress to Done Mar 20, 2021
@AmProsius AmProsius deleted the bug175 branch March 20, 2021 08:44
@AmProsius AmProsius removed their assignment Apr 8, 2021
szapp added a commit that referenced this pull request Apr 19, 2021
@szapp
refactor: simplify test of #175
24b10e0
@szapp szapp removed the validation: required This issue needs validation from one of the validators. label May 14, 2021
@szapp szapp moved this from Instance variable (string) to Item instance variable (string) in Fix templates Feb 5, 2022
@AmProsius AmProsius moved this from Change item instance variable (string) to Change item instance name in Fix templates Jan 10, 2023
@AmProsius AmProsius added the validation: validated This issue is still present even with Systempack/Union. label Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
compatibility: easy This issue is easy to make compatible. impl: replace assign/push str This issue requires replacing pushed strings or string assignments in the scripts. language dependent This issue only occurs in certain localizations. provided fix This issue has a fix provided in the comments. type: session fix The fix for this issues is persistent across a session. validation: validated This issue is still present even with Systempack/Union.
Projects
Fix templates
Change item instance name
v1.1.0
  
Done
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@szapp @AmProsius