The text of items with no value is incomplete in the inventory

[szapp]

Describe the bug
There are items that have no value. In the inventory it shows "Value:" but not number.

Expected behavior
Items with no value no longer show an empty "Value:" in the inventory text.

Additional context
The items have a value of 0 and therefor the value isn't displayed.

The bug has been reported in #177 #178 #179 #180.

[AmProsius]

gothic-1-community-patch/scriptbase/_work/Data/Scripts/Content/Items/MissionItems_1.d

Lines 1101 to 1112 in 2b5e599

	TEXT[0] = "Opens Gomez' chests.";
	////COUNT[0] = ;
	TEXT[1] = "Opens the store in the Ore Barons' cellar.";
	////COUNT[1] = ;
	//TEXT[2] = "";
	//COUNT[2] = ;
	//TEXT[3] = "";
	//COUNT[3] = ;
	//TEXT[4] = "";
	////COUNT[4] = ;
	TEXT[5] = NAME_Value;
	COUNT[5] = value;

changed to

    TEXT[0]             = "Opens Gomez' chests.";
    ////COUNT[0]            = ;
    TEXT[1]             = "Opens the store in the Ore Barons' cellar.";
    ////COUNT[1]            = ;
    //TEXT[2]               = "";
    //COUNT[2]          = ;
    //TEXT[3]           = "";
    //COUNT[3]          = ;
    //TEXT[4]               = "";
    ////COUNT[4]            = ;
    //TEXT[5]             = NAME_Value;
    //COUNT[5]            = value;

[szapp]

For this and all related fixes #177 #178 #179 #180 it might be possible to fix the inventory display in general:

• Either do not show the word "value" if the value is 0,
• Or in fact do show the value even if it is 0.

[AmProsius]

• Either do not show the word "value" if the value is 0,
• Or in fact do show the value even if it is 0.

I'd go with hiding the word value to be consistent with other items (keys) that don't have a value.

[szapp]

I'd go with hiding the word value to be consistent with other items (keys) that don't have a value.

Are there keys that don’t show the word “value”?

[AmProsius]

Are there keys that don’t show the word “value”?

Several. For example the Rice Lord's Key:

gothic-1-community-patch/scriptbase/_work/Data/Scripts/Content/Items/MissionItems_1.d

Lines 1117 to 1130 in 2b5e599

	INSTANCE ItKey_RB_01(C_Item)
	{
	name = "Rice Lord's Bowl";
	mainflag = ITEM_KAT_NONE;
	flags = 0;
	value = 0;
	visual = "ItKe_Key_01.3ds";
	material = MAT_METAL;
	description = name;
	TEXT[0] = "Opens Rice Lord's chest.";
	};

[szapp]

The fix is implemented to remove the display of "Value:" (which is determined from the string constant NAME_Value) from the inventory display if the item value is zero. As of now, the implementation is sub-optimal, because it is a script hook. That is not good in this case, because the hook will be executed 5 times per frame when the inventory is open. I will rewrite it in machine code.