Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bloodwyn doesn't recognize the player's camp membership #18

Closed
AmProsius opened this issue Dec 31, 2020 · 6 comments · Fixed by #71
Closed

Bloodwyn doesn't recognize the player's camp membership #18

AmProsius opened this issue Dec 31, 2020 · 6 comments · Fixed by #71
Labels
impl: hook script func This issue requires hooking script functions. type: session fix The fix for this issues is persistent across a session.
Milestone

Comments

@AmProsius
Copy link
Owner

Bloodwyn still harasses the player for protection money after the player has joined a camp.

@AmProsius AmProsius changed the title Bloodwyn doesn't recognize the players' camp membership Bloodwyn doesn't recognize the player's camp membership Dec 31, 2020
@AmProsius AmProsius removed ai labels Jan 1, 2021
@catalinstoian
Copy link

catalinstoian commented Jan 16, 2021

DIA_GRD_233_Bloodwyn.d

FUNC INT Info_Bloodwyn_Hello_Condition()
{	
	if (Kapitel <= 2) && (Npc_GetTrueGuild(other) == GIL_None)
	{
		return 1;
	};
};

@szapp szapp added the type: session fix The fix for this issues is persistent across a session. label Jan 18, 2021
@szapp
Copy link
Collaborator

szapp commented Jan 18, 2021

If someone wants to give it a try, have a look at #17. It's already implemented (see #65) and this one seems quite similar.

AmProsius added a commit that referenced this issue Jan 18, 2021
#18: Add new condition to Bloodwyn's dialog
@AmProsius AmProsius added this to Done in v1.0.0 Jan 18, 2021
@AmProsius AmProsius added this to the v1.0.0 milestone Feb 9, 2021
@AmProsius AmProsius added this to Info condition in Fix templates Mar 3, 2021
@szapp szapp added the impl: hook script func This issue requires hooking script functions. label Mar 16, 2021
@szapp szapp moved this from Hook Daedalus function to Unsorted in Fix templates Mar 16, 2021
@szapp szapp moved this from Unsorted to Dialog: Info condition in Fix templates Mar 17, 2021
AmProsius added a commit that referenced this issue Apr 13, 2021
@szapp szapp moved this from Modify dialog conditions to Add dialog conditions in Fix templates Feb 6, 2022
@Quintus24
Copy link

Hello, everyone,

Sorry for spamming a closed issue, however, just a heads-up, I still encounter this bug.
I joined the Shadows and Guards guilds, but Bloodwyn keeps asking for protection money.
Additionally, if I choose to pay him, the 10 Ore is not actually deducted and given to him.

I checked the "fix status 18" command and it was displayed as being active.

Regards,
Quintus24

@szapp
Copy link
Collaborator

szapp commented May 1, 2022

Yes, this issue actually addresses the first dialog of Bloodwyn (first encounter) only, but not the follow up reminders. That is a separate dialog, not part of this fix. I am not sure if there is an issue for that one already.

The fix to reduce 10 ore in that follow up dialog is handled in #109. Could you check that fix's status and report any problems in the respective Github issue?

@Quintus24
Copy link

Hi, @szapp,

I think I understand now, sorry for the confusion.
I'll double check #109 and report there what I find.

Regards,
Quintus24

@szapp
Copy link
Collaborator

szapp commented May 1, 2022

No worries, it was luckily very easy to double check. Thanks for bringing the faulty follow-up dialog to our attention. I don’t think it is listed as issue so far. Feel free to open an issue for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impl: hook script func This issue requires hooking script functions. type: session fix The fix for this issues is persistent across a session.
Projects
Fix templates
Add dialog conditions
v1.0.0
  
Done
Development

Successfully merging a pull request may close this issue.

4 participants