Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Corristo sells High Robe multiple times #183

Merged
merged 1 commit into from Apr 2, 2021
Merged

Corristo sells High Robe multiple times #183

merged 1 commit into from Apr 2, 2021

Conversation

AmProsius
Copy link
Owner

Describe the bug
The player can obtain more than one High Robe of Fire from Corristo.

Expected behavior
Corristo now sells only one High Robe of Fire to the player.

Steps to reproduce the issue

  1. Buy High Robe of Fire from Corristo.
  2. Save the game.
  3. Load the save.
  4. Buy another High Robe of Fire from Corristo.

@AmProsius AmProsius added the validation: required This issue needs validation from one of the validators. label Mar 7, 2021
@AmProsius
Copy link
Owner Author

gothic-1-community-patch/scriptbase/_work/Data/Scripts/Content/Story/Missions/DIA_KDF_402_Corristo.d

Lines 601 to 608 in 1301413

FUNC int KDF_402_Corristo_HEAVYARMOR_Condition()
{
if (Npc_GetTrueGuild (hero) == GIL_KDF)
{
return TRUE;
};
};

changed to

FUNC int  KDF_402_Corristo_HEAVYARMOR_Condition()
{
    if (Npc_GetTrueGuild (hero) == GIL_KDF)
    && (!Npc_HasItems(hero, KDF_ARMOR_H)
    {
        return TRUE;
    };

};

@AmProsius AmProsius added provided fix This issue has a fix provided in the comments. compatibility: easy This issue is easy to make compatible. type: session fix The fix for this issues is persistent across a session. labels Mar 7, 2021
@AmProsius AmProsius added this to Info condition in Fix templates Mar 7, 2021
@szapp
Copy link
Collaborator

szapp commented Mar 7, 2021

Similar to #25.

@AmProsius AmProsius added this to To Do in v1.1.0 via automation Mar 11, 2021
@AmProsius AmProsius added this to the v1.1.0 milestone Mar 11, 2021
@szapp szapp added the impl: hook script func This issue requires hooking script functions. label Mar 16, 2021
@szapp szapp moved this from Hook Daedalus function to Unsorted in Fix templates Mar 16, 2021
@szapp szapp moved this from Unsorted to Dialog: Info condition in Fix templates Mar 17, 2021
@AmProsius AmProsius self-assigned this Mar 27, 2021
@AmProsius AmProsius requested a review from szapp April 1, 2021 09:42
@AmProsius AmProsius removed their assignment Apr 1, 2021
@AmProsius AmProsius moved this from To Do to In Progress in v1.1.0 Apr 1, 2021
szapp
szapp approved these changes Apr 2, 2021
View reviewed changes
Copy link
Collaborator

@szapp szapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, test passes.

@szapp szapp merged commit 06785f3 into master Apr 2, 2021
v1.1.0 automation moved this from In Progress to Done Apr 2, 2021
@szapp szapp deleted the bug183 branch April 2, 2021 09:16
AmProsius added a commit that referenced this pull request Apr 15, 2021
@AmProsius
refactor: simplify tests of #25 and #183
0246ffb
@szapp szapp removed the validation: required This issue needs validation from one of the validators. label May 14, 2021
@szapp szapp moved this from Modify dialog conditions to Add dialog conditions in Fix templates Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szapp szapp szapp approved these changes

Assignees
No one assigned
Labels
compatibility: easy This issue is easy to make compatible. impl: hook script func This issue requires hooking script functions. provided fix This issue has a fix provided in the comments. type: session fix The fix for this issues is persistent across a session.
Projects
Fix templates
Add dialog conditions
v1.1.0
  
Done
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AmProsius @szapp