Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bartholo can be given weed multiple times #184

Merged
merged 3 commits into from Apr 11, 2021
Merged

Bartholo can be given weed multiple times #184

merged 3 commits into from Apr 11, 2021

Conversation

AmProsius
Copy link
Owner

@AmProsius AmProsius commented Apr 7, 2021

Describe the bug
The player can give Kalom's weed multiple times to Bartholo.

Expected behavior
Bartholo can now be given Kalom's weed only once.

Steps to reproduce the issue

  1. Sell Kalom's weed to Bartholo.
  2. Save the game.
  3. Load the save.
  4. Sell more weed to Bartholo.

@AmProsius AmProsius added the validation: required This issue needs validation from one of the validators. label Mar 7, 2021
@AmProsius
Copy link
Owner Author

I'm not entirely sure about the solution, but this might work:

FUNC INT Info_Bartholo_Krautbote_Condition()
{
if (Kalom_Krautbote == LOG_RUNNING)
{
return 1;
};
};

changed to

FUNC INT Info_Bartholo_Krautbote_Condition()
{
    if (Kalom_Krautbote == LOG_RUNNING)
    && (Kalom_DeliveredWeed == FALSE)
    {
        return 1;
    };
};

@AmProsius AmProsius added compatibility: easy This issue is easy to make compatible. provided fix This issue has a fix provided in the comments. type: session fix The fix for this issues is persistent across a session. labels Mar 7, 2021
@AmProsius AmProsius added this to Info condition in Fix templates Mar 7, 2021
@AmProsius AmProsius added this to To Do in v1.1.0 via automation Mar 11, 2021
@AmProsius AmProsius added this to the v1.1.0 milestone Mar 11, 2021
@szapp szapp added the impl: hook script func This issue requires hooking script functions. label Mar 16, 2021
@szapp szapp moved this from Hook Daedalus function to Unsorted in Fix templates Mar 16, 2021
@szapp szapp moved this from Unsorted to Dialog: Info condition in Fix templates Mar 17, 2021
@AmProsius AmProsius self-assigned this Mar 29, 2021
@AmProsius
Copy link
Owner Author

Similar to #25.

@AmProsius AmProsius requested a review from szapp April 7, 2021 20:10
@AmProsius AmProsius removed their assignment Apr 7, 2021
@szapp szapp moved this from To Do to In Progress in v1.1.0 Apr 7, 2021
Copy link
Collaborator

@szapp szapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed a mistake in the fix condition (replaced pointer with the new symbol functions). The test passes.

@szapp szapp merged commit 370f14c into master Apr 11, 2021
v1.1.0 automation moved this from In Progress to Done Apr 11, 2021
@szapp szapp deleted the bug184 branch April 11, 2021 18:19
szapp added a commit that referenced this pull request Apr 19, 2021
@szapp szapp removed the validation: required This issue needs validation from one of the validators. label May 14, 2021
@szapp szapp moved this from Modify dialog conditions to Add dialog conditions in Fix templates Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility: easy This issue is easy to make compatible. impl: hook script func This issue requires hooking script functions. provided fix This issue has a fix provided in the comments. type: session fix The fix for this issues is persistent across a session.
Projects
Fix templates
Add dialog conditions
v1.1.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants