New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scorpio offers to teach crossbow multiple times #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AmProsius
added
type: session fix
The fix for this issues is persistent across a session.
compatibility: easy
This issue is easy to make compatible.
validation: required
This issue needs validation from one of the validators.
labels
Mar 7, 2021
gothic-1-community-patch/scriptbase/_work/Data/Scripts/Content/Story/Missions/DIA_GRD_205_Scorpio.d Lines 173 to 182 in 1301413
changed to FUNC int GRD_205_Scorpio_CROSSBOW_Condition()
{
if ((Kapitel >= 4) || (Npc_GetTrueGuild (hero) == GIL_GRD))
&& (Npc_GetTalentSkill(hero, NPC_TALENT_CROSSBOW) < 1)
{
return TRUE;
};
}; |
szapp
added
the
impl: hook script func
This issue requires hooking script functions.
label
Mar 16, 2021
Similar to #25. |
szapp
approved these changes
Apr 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated the fix and test with the new symbol functions. All good, test passes!
szapp
added a commit
that referenced
this pull request
Apr 19, 2021
szapp
removed
the
validation: required
This issue needs validation from one of the validators.
label
May 14, 2021
szapp
moved this from Modify dialog conditions
to Add dialog conditions
in Fix templates
Feb 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
compatibility: easy
This issue is easy to make compatible.
impl: hook script func
This issue requires hooking script functions.
provided fix
This issue has a fix provided in the comments.
type: session fix
The fix for this issues is persistent across a session.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the bug
Scorpio offers to teach crossbow level 1 multiple times, even if the player already gained that skill.
Expected behavior
Scorpio no longer offers to teach crossbow level 1 if the player already gained that skill.
Steps to reproduce the issue