New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Corristo can be asked to join the mages multiple times #186
Conversation
I'm not entirely sure about the solution, but this might work: gothic-1-community-patch/scriptbase/_work/Data/Scripts/Content/Story/Missions/DIA_KDF_402_Corristo.d Lines 98 to 105 in 1301413
changed to FUNC int KDF_402_Corristo_WANNBEKDF_Condition()
{
if ( (CorKalom_BringMCQBalls == LOG_SUCCESS) || Npc_KnowsInfo(hero,GRD_200_Thorus_WANNABEMAGE) )
&& (Npc_GetTrueGuild(hero) == GIL_STT)
&& (Corristo_KDFAufnahme == 0)
{
return TRUE;
};
}; |
Similar to #25. |
Both the fix and the test have not been tested ingame yet. |
src/Ninja/G1CP/Content/Fixes/Session/fix186_CorristoJoinMages.d
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated getting the symbols with the new functions. The test passes.
Describe the bug
The player can ask Corristo to become a mage multiple times, even if he already met the level requirement before.
Expected behavior
Corristo's dialog option to become a mage now disappears when the player has already asked him before and met the level requirements.
Steps to reproduce the issue