New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cor Kalom can be told that the weed was delivered multiple times #188
Conversation
Lines 485 to 491 in 839bd35
changed to func INT Info_Kalom_KrautboteBACK_Condition()
{
if (Kalom_DeliveredWeed)
&& (Kalom_Krautbote == LOG_RUNNING);
{
return TRUE;
};
}; |
Similar to #25. |
symbPtr = MEM_GetSymbol("Kalom_DrugMonopol"); | ||
}; | ||
if (symbPtr) { | ||
if (MEM_ReadInt(symbPtr + zCParSymbol_content_offset) == LOG_SUCCESS) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest taking the inverse of
if (var == LOG_RUNNING) {
return TRUE;
};
So instead I propose to turn this condition here into
if (var != LOG_RUNNING) {
return TRUE;
};
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I managed to not require the fix for #24 to be applied. For example: if (G1CP_IsFixApplied(24)) {
symbId = G1CP_GetIntVarID("Kalom_Krautbote", 0);
} else {
symbId = G1CP_GetIntVarID("Kalom_DrugMonopol", 0);
}; |
Describe the bug
The player can tell Cor Kalom that he delivered the weed multiple times.
Expected behavior
Cor Kalom can now be told that the weed was delivered only once.
Steps to reproduce the issue
Additional context
Fix for #24 has to be applied to successfully apply this fix.