Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scorpio's fight dialog doesn't disappear #19

Closed
AmProsius opened this issue Dec 31, 2020 · 1 comment · Fixed by #75
Closed

Scorpio's fight dialog doesn't disappear #19

AmProsius opened this issue Dec 31, 2020 · 1 comment · Fixed by #75
Labels
impl: hook script func This issue requires hooking script functions. type: session fix The fix for this issues is persistent across a session.
Milestone

Comments

@AmProsius
Copy link
Owner

Scorpio can still be asked "Can you teach me to fight?" after he moves to Cavalorn's, since the dialog line to get him to teach the player is another one.

@AmProsius AmProsius added this to To Do in v1.0.0 via automation Dec 31, 2020
@AmProsius AmProsius removed ai labels Jan 1, 2021
@catalinstoian
Copy link

catalinstoian commented Jan 16, 2021

DIA_GRD_205_Scorpio.d

FUNC int DIA_Scorpio_REFUSETRAIN_Condition()
{
	if (Npc_KnowsInfo(hero,DIA_Scorpio_Hello) && (Npc_GetTrueGuild (hero) != GIL_GRD) && (Kapitel <= 3) )
	{
		return 1;
	};
};

@szapp szapp added the type: session fix The fix for this issues is persistent across a session. label Jan 18, 2021
@AmProsius AmProsius linked a pull request Jan 22, 2021 that will close this issue
v1.0.0 automation moved this from To Do to Done Jan 22, 2021
AmProsius added a commit that referenced this issue Jan 22, 2021
#19: Add condition to Scorpio's fight dialog
@AmProsius AmProsius added this to the v1.0.0 milestone Feb 9, 2021
@AmProsius AmProsius added this to Info condition in Fix templates Mar 7, 2021
szapp added a commit that referenced this issue Mar 13, 2021
@szapp szapp added the impl: hook script func This issue requires hooking script functions. label Mar 16, 2021
@szapp szapp moved this from Hook Daedalus function to Unsorted in Fix templates Mar 16, 2021
@szapp szapp moved this from Unsorted to Dialog: Info condition in Fix templates Mar 17, 2021
AmProsius added a commit that referenced this issue Apr 13, 2021
AmProsius added a commit that referenced this issue Apr 15, 2021
@szapp szapp moved this from Modify dialog conditions to Add dialog conditions in Fix templates Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impl: hook script func This issue requires hooking script functions. type: session fix The fix for this issues is persistent across a session.
Projects
Fix templates
Add dialog conditions
v1.0.0
  
Done
Development

Successfully merging a pull request may close this issue.

3 participants