Mages auto-equip melee/ranged weapons

[szapp]

Describe the bug
Trading with mages (e.g. Xardas or Cronos) will always result in them equipping weapons, because they typically do not wear any to begin with. As soon as the player sells them a weapon (of any type) they will have it equipped when the player returns to them even with #59 applied.

Expected behavior
Mages (NPCs fighting only with spells) no longer auto-equip weapons (e.g. after trading). Requires #59 to be active.

Steps to reproduce the issue

1. Sell a weapon to Xardas
2. Move out of spawn range and come back
3. Xardas now has the weapon equipped (given the weapon does not require too much strength/dexterity)

Additional context

Building on #59:

Trading with mages (e.g. Xardas or Cronos) will always result in them equipping weapons, because they typically do not wear any to begin with. As soon as the player sells them a weapon (of any type) they will have it equipped when the player returns to them even with this fix. There is the option of disabling that for NPCs that exclusively use magic to fight:

gothic-1-community-patch/src/Ninja/G1CP/Content/Fixes/Session/fix059_NpcEquipBestWeapons.d

Lines 38 to 56 in 2972b6e

	func void G1CP_059_NpcEquipBestWeapons_Hook() {
	G1CP_ReportFuncToSpy();
	// Define possibly missing symbols locally
	const int ITEM_KAT_NF = 2;
	const int ITEM_KAT_FF = 4;
	var C_Npc npc; npc = _^(ESI);
	if (!Npc_HasEquippedMeleeWeapon(npc))
	&& (!Npc_HasReadiedMeleeWeapon(npc)) {
	G1CP_NpcEquipBestWeaponByType(npc, ITEM_KAT_NF);
	};
	if (!Npc_HasEquippedRangedWeapon(npc))
	&& (!Npc_HasReadiedRangedWeapon(npc)) {
	G1CP_NpcEquipBestWeaponByType(npc, ITEM_KAT_FF);
	};
	};

changed to

func void G1CP_059_NpcEquipBestWeapons_Hook() {
    G1CP_ReportFuncToSpy();

    // Define possibly missing symbols locally
    const int ITEM_KAT_NF = 2;
    const int ITEM_KAT_FF = 4;
    const int FAI_HUMAN_MAGE = -2;
    if (FAI_HUMAN_MAGE == -2) {
        FAI_HUMAN_MAGE = G1CP_GetIntVar("FAI_HUMAN_MAGE", 0, -1);
    };

    var C_Npc npc; npc = _^(ESI);

    if (!Npc_HasEquippedMeleeWeapon(npc))
    && (!Npc_HasReadiedMeleeWeapon(npc))
    && (npc.fight_tactic != FAI_HUMAN_MAGE) {
        G1CP_NpcEquipBestWeaponByType(npc, ITEM_KAT_NF);
    };

    if (!Npc_HasEquippedRangedWeapon(npc))
    && (!Npc_HasReadiedRangedWeapon(npc))
    && (npc.fight_tactic != FAI_HUMAN_MAGE) {
        G1CP_NpcEquipBestWeaponByType(npc, ITEM_KAT_FF);
    };
};

This should work great in the main game. In mods, however, it could cause issues. If a mod, for example, adds wands or staffs for mages but does not equip them (only adds them to the inventory), they would not show up in the game. Given that those NPCs would only fight with magic anyway it might only cause cosmetic issues - given that the fight AI was not adjusted such the mage-fighters switch to melee in close combat for example.

We could discuss this. In my opinion it would be nice not seeing Xardas with weird orc weapons on his back.

Originally posted by @szapp in #59 (comment)

[szapp]

I suggest to add this fix by modifying the function G1CP_059_NpcEquipBestWeapons_Hook of #59. The modification should only be applied if the fix was not disabled.