Cavalorn not listed as tutor

[AmProsius]

Describe the bug
When asking Fingers about Cavalorn, he is not listed in "Diary/General Info/Tutor outside the camps" if the topic wasn't previously created.

Expected behavior
When asking Fingers about Cavalorn, he is now listed in "Tutor outside the camps" in the journal.

Additional context
Similar to #37 and #203.

[AmProsius]

gothic-1-community-patch/scriptbase/_work/Data/Scripts/Content/Story/Missions/DIA_STT_331_Fingers.d

Lines 220 to 227 in 10bf6e3

	FUNC VOID DIA_Fingers_WhereCavalorn_Info()
	{
	AI_Output (other, self,"DIA_Fingers_WhereCavalorn_15_00"); //Where can I find Cavalorn?
	AI_Output (self, other,"DIA_Fingers_WhereCavalorn_05_01"); //He's hunting out in the wild. You'll find him at the path to the New Camp. Westwards of the Old Camp there's a wide canyon.
	AI_Output (self, other,"DIA_Fingers_WhereCavalorn_05_02"); //In this canyon there's an old woodcutters' hut. You'll find him there.
	B_LogEntry( GE_TeacherOW,"Cavalorn can teach me to sneak. His hut is in a canyon to the west of the Old Camp, in the direction of the New Camp.");
	};

changed to

FUNC VOID DIA_Fingers_WhereCavalorn_Info()
{
    AI_Output (other, self,"DIA_Fingers_WhereCavalorn_15_00"); //Where can I find Cavalorn?
    AI_Output (self, other,"DIA_Fingers_WhereCavalorn_05_01"); //He's hunting out in the wild. You'll find him at the path to the New Camp. Westwards of the Old Camp there's a wide canyon.
    AI_Output (self, other,"DIA_Fingers_WhereCavalorn_05_02"); //In this canyon there's an old woodcutters' hut. You'll find him there.

    Log_CreateTopic(GE_TeacherOW, LOG_NOTE);
    B_LogEntry( GE_TeacherOW,"Cavalorn can teach me to sneak. His hut is in a canyon to the west of the Old Camp, in the direction of the New Camp.");
};

[AmProsius]

Both the fix and the test have not been tested ingame yet.

[AmProsius]

Currently I get Log topic was not auto-created on applying the fix when running test 204, but I don't have a clue why. Also the fix is not applied.

[szapp]

This fix is special, because the dialog is permanent. It's told status will always be false. That means two things:

1. We cannot add the dialog entry post-hoc, since we don't know whether the dialog has been told in the game before.
2. The log entry should be infinite, if I am not mistaken, because the dialog can be triggered indefinitely.

[szapp]

So this fix will have to be implemented differently:

1. Intercept B_LogEntry and create the log topic if it did not exist before (as done in the current implementation already).
2. But also check if that entry already exists and prevent adding it again.
3. Nothing will be applied reverted on saving and loading, because it cannot be checked whether the dialog has been spoken or not. This fix will thereby be no longer a revertible fix.

I will make the necessary adjustments.

[szapp]

I rewrote the fix. Please note the commit message body above, as to why I adjusted the changelog as well.

[szapp]

@AmProsius I cannot assign you as reviewer as you opened the pull request.