New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wolf not listed as merchant #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AmProsius
added
type: revert on save
The fix for this issue impacts the game and should be reverted when saving.
compatibility: difficult
This issue is difficult to make compatible.
validation: required
This issue needs validation from one of the validators.
provided fix
This issue has a fix provided in the comments.
impl: modify/analyze script func
This issue requires analyzing and/or modifying the bytecode of script functions.
labels
Mar 26, 2021
gothic-1-community-patch/scriptbase/_work/Data/Scripts/Content/Story/Missions/DIA_ORG_855_Wolf.d Lines 45 to 51 in 10bf6e3
changed to FUNC VOID DIA_Wolf_Hello_Info()
{
AI_Output (other, self,"DIA_Wolf_Hello_15_00"); //Who are you?
AI_Output (self, other,"DIA_Wolf_Hello_09_01"); //I'm Wolf. I make armor.
Log_CreateTopic(GE_TraderNC, LOG_NOTE);
B_LogEntry (GE_TraderNC,"Wolf supplies the rogues with ARMOR. He's usually in front of his hut in the big living cave.");
}; |
Is that issue-fix avalaible only for english version ? Log is in English . Nevermind. You have added Log_CreateTopic(GE_TeacherNC, LOG_NOTE) and it should solve the issue now. |
Both the fix and the test have not been tested ingame yet. |
szapp
approved these changes
Apr 17, 2021
AmProsius
added a commit
that referenced
this pull request
Apr 19, 2021
szapp
added a commit
that referenced
this pull request
Apr 19, 2021
szapp
removed
the
validation: required
This issue needs validation from one of the validators.
label
May 14, 2021
szapp
moved this from Modify dialog function
to Add missing log creation
in Fix templates
Feb 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
compatibility: difficult
This issue is difficult to make compatible.
impl: modify/analyze script func
This issue requires analyzing and/or modifying the bytecode of script functions.
provided fix
This issue has a fix provided in the comments.
type: revert on save
The fix for this issue impacts the game and should be reverted when saving.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the bug
Wolf is not listed in "Diary/General Info/Merchant in the New Camp" if the topic wasn't previously created.
Expected behavior
Wolf is now listed in "Merchant in the New Camp" in the journal.
Additional context
Similar to #37, #203 and #204.