Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cauldron in the New Camp can be used without a scoop pt. 1 #212

Merged
merged 2 commits into from Apr 18, 2021
Merged

Cauldron in the New Camp can be used without a scoop pt. 1 #212

merged 2 commits into from Apr 18, 2021

Conversation

szapp
Copy link
Collaborator

@szapp szapp commented Apr 17, 2021 •
edited

Describe the bug
The cauldron near the ore heap in the New Camp can be used without having a Scoop in the inventory.

Expected behavior
The cauldron near the ore heap in the New Camp now correctly requires a scoop to use.

Additional context

Screenhots
ScreenShot_2021_2_4_23_3_1

@szapp szapp added type: world bug This issue requires editing properties of objects in the game world. compatibility: easy This issue is easy to make compatible. validation: validated This issue is still present even with Systempack/Union. provided fix This issue has a fix provided in the comments. impl: change obj var This issue requires changing properties of objects. labels Mar 28, 2021
@szapp szapp added this to the v1.1.0 milestone Mar 28, 2021
@szapp szapp added this to To Do in v1.1.0 via automation Mar 28, 2021
This was referenced Mar 28, 2021
Merged
Merged
@szapp szapp added this to VOB property in Fix templates Mar 28, 2021
@AmProsius AmProsius self-assigned this Mar 28, 2021
@szapp
Copy link
Collaborator Author

szapp commented Mar 28, 2021 •
edited

Here is some instruction to find the exact coordinates of a VOB:

  • Start the spacer.exe in the System directory of Gothic. It may be necessary to remove the patch if starting does not succeed.
  • Load the entire world (world.zen) or world file corresponding to the world part in which the VOB resides. The files are located in \work\_Data\Worlds\_work. If there are no files extract them from \Data\worlds.vdf.
  • Find the VOB. Either by flying towards it or in the object list.
  • Open the Internals section of the object property window
  • Select the entry trafoOSToWSPos
  • Copy the three floating-point values in the bottom
  • These values can be used in conjunction with G1CP_FindVobByPosF(float x, float y, float z).

image

@szapp szapp mentioned this pull request Apr 2, 2021
Merged
@szapp szapp self-assigned this Apr 16, 2021
szapp added a commit that referenced this pull request Apr 17, 2021
@szapp
feat: require spoon for cauldron 2
361f898 
Refs #212
@szapp szapp moved this from To Do to In Progress in v1.1.0 Apr 17, 2021
@szapp szapp requested a review from AmProsius April 17, 2021 09:28
AmProsius
AmProsius previously requested changes Apr 18, 2021
View reviewed changes
Copy link
Owner

@AmProsius AmProsius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The player character now gets a scoop if he didn't have one before and uses the cauldron.

@AmProsius AmProsius dismissed their stale review April 18, 2021 19:26

The player character gets the scoop with the test.

@AmProsius AmProsius merged commit 3e00235 into master Apr 18, 2021
v1.1.0 automation moved this from In Progress to Done Apr 18, 2021
@AmProsius AmProsius deleted the bug212 branch April 18, 2021 19:27
szapp added a commit that referenced this pull request Apr 20, 2021
@szapp
refactor: simplify test of #212
443624d
@szapp szapp mentioned this pull request May 13, 2021
Merged
szapp added a commit that referenced this pull request Jan 18, 2022
@szapp
Refactor finding VOBs to narrow down by class
1718b90 
Finding VOBs by their exact position can now be further narrowed down by
their class. Like before only the first matching VOB will be found. The
function can now also detect light VOBs which where previously ignored.
For details, see the header commment of ent of 'G1CP_FindVobByPosPtr'.
Common class definitions are defined as constants in constants.d. All
affected fixes are updated.

Refs #46 #51 #52 #127 #212 #213 #226
szapp added a commit that referenced this pull request Jan 19, 2022
@szapp
Extend finding VOBs further with callback
f67dc46 
Instead of specifying a class to narrow down the search (see previous
commit), the option is now more versatile: Now the last parameter is a
callback function. It can either be one of the existing class check
functions or a custom function to narrow down the search more flexibly
and potentially based on more or more complex checks.

Refs #46 #51 #52 #127 #212 #213 #226
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AmProsius AmProsius AmProsius left review comments

Assignees
No one assigned
Labels
compatibility: easy This issue is easy to make compatible. impl: change obj var This issue requires changing properties of objects. provided fix This issue has a fix provided in the comments. type: world bug This issue requires editing properties of objects in the game world. validation: validated This issue is still present even with Systempack/Union.
Projects
Fix templates
Change VOB property
v1.1.0
  
Done
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@szapp @AmProsius