New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Graham doesn't sit at campfire #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AmProsius
added
the
validation: required
This issue needs validation from one of the validators.
label
Mar 28, 2021
gothic-1-community-patch/scriptbase/_work/Data/Scripts/Content/Story/NPC/VLK_573_Graham.d Lines 56 to 65 in ce4cd58
changed to FUNC VOID Rtn_start_573 ()
{
TA_Sleep (22,30,06,00,"OCR_HUT_76");
TA_SitAround (06,00,07,00,"OCR_OUTSIDE_HUT_76");
TA_StandAround (07,00,11,00,"OCR_OUTSIDE_HUT_77_INSERT");
TA_WashSelf (11,00,11,30,"OCR_LAKE_4");
TA_RepairHut (11,30,12,00,"OCR_OUTSIDE_HUT_76");
TA_Boss (12,00,18,00,"OCR_HUT_76");
TA_SitCampfire (18,00,22,30,"OCR_OUTSIDE_HUT_77_INSERT");
}; |
szapp
added
compatibility: easy
This issue is easy to make compatible.
impl: replace assign/push str
This issue requires replacing pushed strings or string assignments in the scripts.
type: session fix
The fix for this issues is persistent across a session.
labels
Mar 28, 2021
The test requires manual confirmation. It may happen that Graham still stands around, if the other digger happens to chose to sit at Graham's spot. That's not so likely (only if the PC stands in the way during their change in routines, at 6 PM). |
szapp
added a commit
that referenced
this pull request
Apr 19, 2021
szapp
removed
the
validation: required
This issue needs validation from one of the validators.
label
May 14, 2021
szapp
added a commit
that referenced
this pull request
Feb 6, 2022
szapp
added a commit
that referenced
this pull request
Feb 6, 2022
AmProsius
added
the
validation: validated
This issue is still present even with Systempack/Union.
label
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
compatibility: easy
This issue is easy to make compatible.
impl: replace assign/push str
This issue requires replacing pushed strings or string assignments in the scripts.
provided fix
This issue has a fix provided in the comments.
type: session fix
The fix for this issues is persistent across a session.
validation: validated
This issue is still present even with Systempack/Union.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the bug
Graham is supposed to sit at the campfire in the evening, but a typo in the waypoint name prevents him from doing so.
Expected behavior
Graham now correctly sits at the campfire in the evening.
Additional context
Bug and fix provided by NikX94.