Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guy doesn't sit at arena #215

Merged
merged 1 commit into from Apr 2, 2021
Merged

Guy doesn't sit at arena #215

merged 1 commit into from Apr 2, 2021

Conversation

AmProsius
Copy link
Owner

@AmProsius AmProsius commented Apr 1, 2021 •
edited by szapp

Describe the bug
Guy is supposed to sit at the arena in the evening, but a typo in the waypoint name prevents him from doing so.

Expected behavior
Guy now correctly sits at the arena in the evening.

Additional context
Bug and fix provided by NikX94.

@AmProsius AmProsius added the validation: required This issue needs validation from one of the validators. label Mar 28, 2021
@AmProsius
Copy link
Owner Author

gothic-1-community-patch/scriptbase/_work/Data/Scripts/Content/Story/NPC/VLK_530_Guy.d

Lines 50 to 57 in ce4cd58

FUNC VOID Rtn_start_530 ()
{
TA_Sleep (23,00,07,00,"OCR_HUT_25");
TA_SitAround (07,00,08,00,"OCR_OUTSIDE_HUT_25");
TA_Smalltalk (08,00,17,00,"OCR_OUTSIDE_HUT_27"); //mit Stt 306
TA_SitAround (17,00,19,05,"OCR_OUTSIDE_ARENA_BENCH_2");
TA_ArenaSpectator(19,05,23,00,"OCR_ARENA_07");
};

changed to

FUNC VOID Rtn_start_530 ()
{
    TA_Sleep        (23,00,07,00,"OCR_HUT_25");
    TA_SitAround    (07,00,08,00,"OCR_OUTSIDE_HUT_25");
    TA_Smalltalk    (08,00,17,00,"OCR_OUTSIDE_HUT_27"); //mit Stt 306
    TA_SitAround    (17,00,19,05,"OCR_OUTSIDE_ARENA_BENCH2");
    TA_ArenaSpectator(19,05,23,00,"OCR_ARENA_07");
};

@AmProsius AmProsius added the provided fix This issue has a fix provided in the comments. label Mar 28, 2021
@szapp szapp added compatibility: easy This issue is easy to make compatible. impl: replace assign/push str This issue requires replacing pushed strings or string assignments in the scripts. type: session fix The fix for this issues is persistent across a session. labels Mar 28, 2021
@N1kX94 N1kX94 mentioned this pull request Mar 31, 2021
Open
@szapp szapp added this to NPC daily routine in Fix templates Mar 31, 2021
@szapp
Copy link
Collaborator

szapp commented Mar 31, 2021

I added an example fix with #214.

@szapp
Copy link
Collaborator

szapp commented Mar 31, 2021

Should we add these (quick to fix) daily routine issues to v1.1.0?

@AmProsius
Copy link
Owner Author

Should we add these (quick to fix) daily routine issues to v1.1.0?

Yes, good idea.

@AmProsius AmProsius added this to To Do in v1.1.0 via automation Mar 31, 2021
@AmProsius AmProsius added this to the v1.1.0 milestone Mar 31, 2021
@AmProsius AmProsius requested a review from szapp April 1, 2021 09:56
@AmProsius AmProsius removed their assignment Apr 1, 2021
@AmProsius AmProsius moved this from To Do to In Progress in v1.1.0 Apr 1, 2021
szapp
szapp approved these changes Apr 2, 2021
View reviewed changes
Copy link
Collaborator

@szapp szapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, test passes.

@szapp szapp merged commit 4d01a96 into master Apr 2, 2021
v1.1.0 automation moved this from In Progress to Done Apr 2, 2021
@szapp szapp deleted the bug215 branch April 2, 2021 09:27
szapp added a commit that referenced this pull request Apr 19, 2021
@szapp
refactor: simplify test of #215
d962cd4
@szapp szapp removed the validation: required This issue needs validation from one of the validators. label May 14, 2021
szapp added a commit that referenced this pull request Feb 6, 2022
@szapp
Add routine functions, automate some tests
c6712a6 
Refs #214 #215 #216 #217
szapp added a commit that referenced this pull request Feb 6, 2022
@szapp
Adjust daily routine automatic tests
f66fcca 
Refs #122 #214 #215 #216 #217
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szapp szapp szapp approved these changes

Assignees
No one assigned
Labels
compatibility: easy This issue is easy to make compatible. impl: replace assign/push str This issue requires replacing pushed strings or string assignments in the scripts. provided fix This issue has a fix provided in the comments. type: session fix The fix for this issues is persistent across a session.
Projects
Fix templates
Change daily routine waypoint
v1.1.0
  
Done
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AmProsius @szapp