New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Female SVM subtitles don't match the audio (EN) #278
Conversation
If this is a general issue, maybe we can can get to the root of it and fix it in one place. |
I assume the few women dialog lines are collected in one common place. To adjust the subtitle to match the audio, we'd have to ring in a new kind of fix kind. Subtitles (termed Output Units or in short OU) are strictly speaking only indirectly related to the scripts. We will have to find the respective OU in the generated OU library and replace their text.
To Do
|
Related portion in the scripts: gothic-1-community-patch/scriptbase/_work/Data/Scripts/Content/Story/SVM.d Lines 2155 to 2164 in 41f81d1
|
@AmProsius The subtitle (output unit) related fixes seem quite easy. If you don't mind I will leave them to you, given this fix as a template. |
Before we merge this, we should discuss the test that I have written (see comment above). |
Before merging, I also wanna change the name of this bug fix. "Ambient women dialog subtitles don't match the audio" is technically incorrect. In this case it is not a dialog but an SVM. |
src/Ninja/G1CP/Content/Fixes/Session/fix278_EN_WomanOuMismatch.d
Outdated
Show resolved
Hide resolved
src/Ninja/G1CP/Content/Fixes/Session/fix278_EN_WomanOuMismatch.d
Outdated
Show resolved
Hide resolved
There is no need to fix it for PL version. |
Hello, everyone!
I would like to report the following bug:
Describe the bug:
This issue can be encountered in the Swamp Camp or Old Camp when speaking with any of the ladies NPC.
Interacting with them, they will say: "Shh, you're not allowed to talk to us.".
However, the Subtitle is displayed as: "Just go! You're not supposed to talk to me!".
Expected behavior:
The subtitles of female NPCs now match the audio.
Steps to reproduce the issue:
Additional context
Note that this is not an actual conversation with the player character, there is no dialogue box.
The generic subtitle is displayed in "red" and behaves like the ones when NPC are talking with each other.
Audio: "Shh, you're not allowed to talk to us."
Subtitle: "Just go! You're not supposed to talk to me!"
NPC affected by this issue: Seraphia, Syra, Natalia, Chani.
These are the ones I encountered so far, I think there are a few more, but I have not found them.
Regardless, most likely it's a general issue for all of them.
Attaching some screenshots for more clear information.
Chani - Swamp Camp.
Natalia - Swamp Camp.
Thank You and Best Regards!
Quintus24