Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Female SVM subtitles don't match the audio (EN) #278

Merged
merged 4 commits into from Jan 18, 2022
Merged

Female SVM subtitles don't match the audio (EN) #278

merged 4 commits into from Jan 18, 2022

Conversation

szapp
Copy link
Collaborator

@szapp szapp commented Jan 16, 2022

Hello, everyone!

I would like to report the following bug:

Describe the bug:
This issue can be encountered in the Swamp Camp or Old Camp when speaking with any of the ladies NPC.
Interacting with them, they will say: "Shh, you're not allowed to talk to us.".
However, the Subtitle is displayed as: "Just go! You're not supposed to talk to me!".

Expected behavior:
The subtitles of female NPCs now match the audio.

Steps to reproduce the issue:

  1. Travel to the Old Camp or the Swamp Camp.
  2. Speak with any of the Ladies NPC.
  3. Listen and notice the Audio/Subtitle mismatch.

Additional context
Note that this is not an actual conversation with the player character, there is no dialogue box.
The generic subtitle is displayed in "red" and behaves like the ones when NPC are talking with each other.

Audio: "Shh, you're not allowed to talk to us."
Subtitle: "Just go! You're not supposed to talk to me!"

NPC affected by this issue: Seraphia, Syra, Natalia, Chani.
These are the ones I encountered so far, I think there are a few more, but I have not found them.
Regardless, most likely it's a general issue for all of them.

Attaching some screenshots for more clear information.

  1. Chani - Swamp Camp.
    Chani - Swamp Camp

  2. Natalia - Swamp Camp.
    Natalia - Swamp Camp

Thank You and Best Regards!
Quintus24

@Quintus24 Quintus24 added the validation: required This issue needs validation from one of the validators. label Jan 1, 2022
@AmProsius
Copy link
Owner

If this is a general issue, maybe we can can get to the root of it and fix it in one place.

@szapp
Copy link
Collaborator

szapp commented Jan 8, 2022

If this is a general issue, maybe we can can get to the root of it and fix it in one place.

I assume the few women dialog lines are collected in one common place.

To adjust the subtitle to match the audio, we'd have to ring in a new kind of fix kind. Subtitles (termed Output Units or in short OU) are strictly speaking only indirectly related to the scripts. We will have to find the respective OU in the generated OU library and replace their text.

Since the OU library is generated only once at beginning of a new game, this will have to be a revertible fix. I remembered that wrong: The info manager (containing the info instances) is saved to the game save, the OU library is regenerated at each start. Therefore, these fixes are session fixes.

Related to #251 and #274.

To Do

  • We should investigate if this is happens in more languages.

@szapp szapp added compatibility: difficult This issue is difficult to make compatible. impl: change obj var This issue requires changing properties of objects. type: revert on save The fix for this issue impacts the game and should be reverted when saving. labels Jan 8, 2022
@szapp szapp added this to Other in Fix templates Jan 8, 2022
@szapp szapp self-assigned this Jan 8, 2022
@szapp szapp changed the title Audio/Subtitle mismatch from the women NPC. Ambient women dialog subtitles don't match the audio (EN) Jan 8, 2022
@szapp szapp added the language dependent This issue only occurs in certain localizations. label Jan 8, 2022
@szapp szapp moved this from Other to Dialog: Subtitles in Fix templates Jan 10, 2022
@szapp szapp added type: session fix The fix for this issues is persistent across a session. compatibility: easy This issue is easy to make compatible. and removed type: revert on save The fix for this issue impacts the game and should be reverted when saving. compatibility: difficult This issue is difficult to make compatible. labels Jan 16, 2022
@szapp
Copy link
Collaborator

szapp commented Jan 16, 2022

Related portion in the scripts:

//////////////////////////////////////////
INSTANCE SVM_16 (C_SVM) // Stimmbeschreibung : Babes halt!!!!!
{
NotNow = "SVM_16_NotNow" ; //Just go! You're not supposed to talk to me!
Help = "SVM_16_Help" ; //Scream!
Aargh_1 = "SVM_16_Aargh_1" ; //Aargh
Aargh_2 = "SVM_16_Aargh_2" ; //Aargh
Aargh_3 = "SVM_16_Aargh_3" ; //Aargh
Dead = "SVM_16_Dead" ; //Aaargl
};

@szapp
Copy link
Collaborator

szapp commented Jan 16, 2022

@AmProsius The subtitle (output unit) related fixes seem quite easy. If you don't mind I will leave them to you, given this fix as a template.

@szapp
Copy link
Collaborator

szapp commented Jan 16, 2022

Before we merge this, we should discuss the test that I have written (see comment above).

@szapp
Copy link
Collaborator

szapp commented Jan 18, 2022

Before merging, I also wanna change the name of this bug fix. "Ambient women dialog subtitles don't match the audio" is technically incorrect. In this case it is not a dialog but an SVM.

@szapp szapp changed the title Ambient women dialog subtitles don't match the audio (EN) Ambient women SVM subtitles don't match the audio (EN) Jan 18, 2022
CHANGELOG.md Outdated Show resolved Hide resolved
@szapp szapp changed the title Ambient women SVM subtitles don't match the audio (EN) Female NPC SVM subtitles don't match the audio (EN) Jan 18, 2022
@szapp szapp changed the title Female NPC SVM subtitles don't match the audio (EN) Female SVM subtitles don't match the audio (EN) Jan 18, 2022
@AmProsius AmProsius merged commit db37be7 into master Jan 18, 2022
@AmProsius AmProsius deleted the bug278 branch January 18, 2022 15:28
v1.3.0 automation moved this from In Progress to Done Jan 18, 2022
@pawbuj1981
Copy link

There is no need to fix it for PL version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility: easy This issue is easy to make compatible. impl: change obj var This issue requires changing properties of objects. language dependent This issue only occurs in certain localizations. type: session fix The fix for this issues is persistent across a session. validation: required This issue needs validation from one of the validators.
Projects
Fix templates
Change dialog subtitles
v1.3.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants