Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buster trains Acrobatics multiple times #29

Closed
AmProsius opened this issue Jan 4, 2021 · 1 comment · Fixed by #86
Closed

Buster trains Acrobatics multiple times #29

AmProsius opened this issue Jan 4, 2021 · 1 comment · Fixed by #86
Labels
compatibility: easy This issue is easy to make compatible. impl: hook script func This issue requires hooking script functions. type: session fix The fix for this issues is persistent across a session.
Milestone

Comments

@AmProsius
Copy link
Owner

Buster still teaches Acrobatics after the skill is already gained.

@AmProsius AmProsius added this to To Do in v1.0.0 via automation Jan 4, 2021
@catalinstoian
Copy link

catalinstoian commented Jan 16, 2021

FUNC INT DIA_ORG_833_Buster3_Condition()
{
return Npc_KnowsInfo(hero,DIA_ORG_833_Buster);
};

changed to

FUNC INT DIA_ORG_833_Buster3_Condition()
{	
	if (Npc_KnowsInfo(hero,DIA_ORG_833_Buster)) && (Npc_GetTalentSkill(hero, NPC_TALENT_ACROBAT) == 0) {
	return 1;
	};
};

@szapp szapp added type: session fix The fix for this issues is persistent across a session. compatibility: easy This issue is easy to make compatible. labels Jan 24, 2021
v1.0.0 automation moved this from To Do to Done Jan 26, 2021
AmProsius added a commit that referenced this issue Jan 26, 2021
#29: Make Buster only teach Acrobatics once
@AmProsius AmProsius added this to the v1.0.0 milestone Feb 9, 2021
@AmProsius AmProsius added this to Info condition in Fix templates Mar 7, 2021
@szapp szapp added the impl: hook script func This issue requires hooking script functions. label Mar 16, 2021
@szapp szapp moved this from Hook Daedalus function to Unsorted in Fix templates Mar 16, 2021
@szapp szapp moved this from Unsorted to Dialog: Info condition in Fix templates Mar 17, 2021
AmProsius added a commit that referenced this issue Apr 15, 2021
szapp added a commit that referenced this issue Apr 19, 2021
@szapp szapp moved this from Modify dialog conditions to Add dialog conditions in Fix templates Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility: easy This issue is easy to make compatible. impl: hook script func This issue requires hooking script functions. type: session fix The fix for this issues is persistent across a session.
Projects
Fix templates
Add dialog conditions
v1.0.0
  
Done
Development

Successfully merging a pull request may close this issue.

3 participants