Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Silas trades only one time #30

Closed
AmProsius opened this issue Jan 4, 2021 · 1 comment · Fixed by #108
Closed

Silas trades only one time #30

AmProsius opened this issue Jan 4, 2021 · 1 comment · Fixed by #108
Labels
compatibility: easy This issue is easy to make compatible. impl: replace assign int This issue requires replacing integer assignments in the scripts. provided fix This issue has a fix provided in the comments. type: session fix The fix for this issues is persistent across a session. validation: validated This issue is still present even with Systempack/Union.
Projects
v1.0.0 Fix templates
Milestone
v1.0.0

Comments

@AmProsius
Copy link
Owner

Silas trades with the player only once.
@AmProsius AmProsius added this to To Do in v1.0.0 via automation Jan 4, 2021
@catalinstoian
Copy link

catalinstoian commented Jan 16, 2021 •
edited by szapp

gothic-1-community-patch/scriptbase/_work/Data/Scripts/Content/Story/Missions/DIA_ORG_841_Silas.d

Lines 55 to 64 in e66b303

INSTANCE DIA_Silas_Trade(C_Info)
{
npc = Org_841_Silas;
nr = 1;
condition = DIA_Silas_Trade_Condition;
information = DIA_Silas_Trade_Info;
permanent = 0;
description = "I want a drink.";
trade = 1;
};

changed to

INSTANCE DIA_Silas_Trade(C_Info)
{
	npc			= Org_841_Silas;
	nr			= 1;
	condition	= DIA_Silas_Trade_Condition;
	information	= DIA_Silas_Trade_Info;
	permanent	= 1;
	description = "I want a drink.";
	trade		= 1;
};

@szapp szapp added type: session fix The fix for this issues is persistent across a session. type: revert on save The fix for this issue impacts the game and should be reverted when saving. compatibility: difficult This issue is difficult to make compatible. and removed type: session fix The fix for this issues is persistent across a session. labels Jan 24, 2021
@AmProsius AmProsius removed this from To Do in v1.0.0 Jan 26, 2021
@AmProsius AmProsius added this to To Do in v1.0.0 Feb 9, 2021
@AmProsius AmProsius added this to the v1.0.0 milestone Feb 9, 2021
@szapp szapp added compatibility: easy This issue is easy to make compatible. type: session fix The fix for this issues is persistent across a session. and removed compatibility: difficult This issue is difficult to make compatible. type: revert on save The fix for this issue impacts the game and should be reverted when saving. labels Feb 9, 2021
@szapp szapp moved this from To Do to In Progress in v1.0.0 Feb 9, 2021
szapp added a commit that referenced this issue Feb 9, 2021
@szapp
#30: Silas now trades with the player more than once
e531fbe
@szapp szapp mentioned this issue Feb 9, 2021
Merged
v1.0.0 automation moved this from In Progress to Done Feb 11, 2021
AmProsius added a commit that referenced this issue Feb 11, 2021
@AmProsius
Merge pull request #108 from AmProsius/bug030
b8996cb 
#30: Silas now trades with the player more than once
szapp added a commit that referenced this issue Feb 11, 2021
@szapp
Fix symbol index check in #30
1b29325
@szapp szapp mentioned this issue Feb 16, 2021
Closed
@AmProsius AmProsius added this to Item property (int) in Fix templates Mar 1, 2021
@szapp szapp added impl: modify/analyze script func This issue requires analyzing and/or modifying the bytecode of script functions. impl: replace assign int This issue requires replacing integer assignments in the scripts. labels Mar 17, 2021
@szapp szapp removed the impl: modify/analyze script func This issue requires analyzing and/or modifying the bytecode of script functions. label Mar 17, 2021
AmProsius added a commit that referenced this issue Apr 15, 2021
@AmProsius
refactor: simplify test of #30
0649e31
@szapp szapp mentioned this issue Dec 22, 2021
Open
@szapp szapp moved this from Instance variable (int) to Info instance variable (int) in Fix templates Feb 5, 2022
@AmProsius AmProsius mentioned this issue Feb 19, 2024
Open
@AmProsius AmProsius added validation: validated This issue is still present even with Systempack/Union. provided fix This issue has a fix provided in the comments. labels Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compatibility: easy This issue is easy to make compatible. impl: replace assign int This issue requires replacing integer assignments in the scripts. provided fix This issue has a fix provided in the comments. type: session fix The fix for this issues is persistent across a session. validation: validated This issue is still present even with Systempack/Union.
Projects
Fix templates
Change info instance variable (int)
v1.0.0
  
Done
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

#30: Silas now trades with the player more than once AmProsius/gothic-1-community-patch
3 participants
@AmProsius @catalinstoian @szapp