Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wolf's minecrawler plate dialog doesn't disappear #31

Closed
AmProsius opened this issue Jan 4, 2021 · 1 comment · Fixed by #90
Closed

Wolf's minecrawler plate dialog doesn't disappear #31

AmProsius opened this issue Jan 4, 2021 · 1 comment · Fixed by #90
Labels
compatibility: easy This issue is easy to make compatible. impl: hook script func This issue requires hooking script functions. type: session fix The fix for this issues is persistent across a session.
Projects
v1.0.0 Fix templates
Milestone
v1.0.0

Comments

@AmProsius
Copy link
Owner

Wolf can be offered minecrawlers' armor plates even if the player already did so.
@AmProsius AmProsius added this to To Do in v1.0.0 via automation Jan 4, 2021
@catalinstoian
Copy link

catalinstoian commented Jan 16, 2021 •
edited by szapp

gothic-1-community-patch/scriptbase/_work/Data/Scripts/Content/Story/Missions/DIA_ORG_855_Wolf.d

Lines 556 to 564 in e66b303

FUNC INT Info_Wolf_MCPLATESFEW_Condition()
{
if (Knows_GetMCPlates)
&& (Npc_HasItems(hero, ItAt_Crawler_02) > 0)
&& (Npc_HasItems(hero, ItAt_Crawler_02) < 15)
{
return TRUE;
};
};

gothic-1-community-patch/scriptbase/_work/Data/Scripts/Content/Story/Missions/DIA_ORG_855_Wolf.d

Lines 586 to 593 in e66b303

FUNC INT Info_Wolf_MCPLATESENOUGH_Condition()
{
if (Knows_GetMCPlates)
&& (Npc_HasItems(hero, ItAt_Crawler_02) >= 15)
{
return TRUE;
};
};

changed to

FUNC INT Info_Wolf_MCPLATESFEW_Condition()
{
	if	(Knows_GetMCPlates)
	&&	(Npc_HasItems(hero, ItAt_Crawler_02) > 0)
	&&	(Npc_HasItems(hero, ItAt_Crawler_02) < 15)
	&&	(!Npc_KnowsInfo(hero, Info_Wolf_MCPLATESENOUGH))
	{
		return TRUE;
	};
};
FUNC INT Info_Wolf_MCPLATESENOUGH_Condition()
{
	if	(Knows_GetMCPlates)
	&&	(Npc_HasItems(hero, ItAt_Crawler_02) >= 15)
	&&	(!Npc_KnowsInfo(hero, Info_Wolf_MCPLATESENOUGH))
	{
		return TRUE;
	};
};

@szapp szapp added type: session fix The fix for this issues is persistent across a session. compatibility: easy This issue is easy to make compatible. labels Jan 24, 2021
szapp added a commit that referenced this issue Jan 31, 2021
@szapp
#31: Remove Wolf's plate dialog
f198ed3
@szapp szapp mentioned this issue Jan 31, 2021
Merged
v1.0.0 automation moved this from To Do to Done Feb 1, 2021
AmProsius added a commit that referenced this issue Feb 1, 2021
@AmProsius
Merge pull request #90 from AmProsius/bug031
0704975 
#31: Remove Wolf's plate dialog
@AmProsius AmProsius added this to the v1.0.0 milestone Feb 9, 2021
@szapp szapp added this to Dialog: Info condition in Fix templates Mar 17, 2021
@szapp szapp added the impl: hook script func This issue requires hooking script functions. label Mar 17, 2021
AmProsius added a commit that referenced this issue Apr 15, 2021
@AmProsius
refactor: simplify test of #31
7053070
@szapp szapp moved this from Modify dialog conditions to Add dialog conditions in Fix templates Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compatibility: easy This issue is easy to make compatible. impl: hook script func This issue requires hooking script functions. type: session fix The fix for this issues is persistent across a session.
Projects
Fix templates
Add dialog conditions
v1.0.0
  
Done
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

#31: Remove Wolf's plate dialog AmProsius/gothic-1-community-patch
3 participants
@AmProsius @catalinstoian @szapp