Gorn attacks the player in the Free Mine

[szapp]

Describe the bug
Gorn sometimes attacks the player on the raid of the Free Mine.

Expected behavior
Gorn no longer attacks the player on the raid of the Free Mine.

Test
Run manual test with test 32.

• Gorn no longer scolds the player for killing NPCs of the Old Camp when talking to him.
  Triggered by killing a guard when out of sight of Gorn.
• Gorn no longer warns the player of attacking him again when talking to him.
  Triggered by defeating guards of the Old Camp.
• Gorn no longer attacks the player.
  Triggered by Gorn seeing a guard of the Old Camp attacking the PC first.

[szapp]

I'd like to find out what exactly is the origin of the problem. I had a look at the scripts and theoretically Gorn should not attack, because he is both of NPC-type "friend" and (most of the time) even a party member. According to the damage assessment functions it looks like, that should be enough to tolerate damage from enemies.

It's nice that we now have a better angle, looking like the attitude may play a role. Given @catalinstoian remarks that this approach might not be so robust, we might find a way to permanently set Gorn's attitude (without it resetting) or get to the root of the actual problem in the scripts.

[szapp]

Gorn's line "A member of the Old Camp is dead, and your name was mentioned in connection with his death ..." is triggered from the function B_ReactToMemory. The news system seems quite wide spread throughout the scripts. Gorn could have either witnessed the murder or it was conveyed by what the scripts refer to as "gossip" (possibly from the guards of the old camp). The news about a murder seem to be exclusively set in B_AssessAndMemorize which is called from a number of other functions.

I can disable his message successfully by deleting his news. It indeed turns out to be unrelated to his hostility. But it seems to be triggered through a similar event. It seems like Gorn is witnessing himself defeating a guard.

[AmProsius]

Is there anything I can do (ingame) to narrow the issue down?

[szapp]

Not sure at the moment. I am currently trying to dissect the function calls to see what is the origin for Gorn's attitude.

[szapp]

I pushed some preliminary checks made so far and also have a test here already (test 32 manual).

[szapp]

I had looked at it last night a little bit and I identified the reason for Gorn attacking. This is the script debug output.

When Gorn is following the PC who is being attacked (by an NPC out of range for Gorn), Gorn's fight sound perception is triggered. In the function B_AssessFightSound, the function C_ChargeWasAttacked correctly determines that an NPC attacked an ally of Gorn (i.e. the PC). This correctly triggers the state ZS_ProclaimAndPunish for Gorn. However, that function falsely assumes that the offender is the PC. Instead of attacking other, the script has Gorn attack hero. That is exactly the inconsistency between other and hero we recently discussed. Actually, it seems fine. The problem is that B_AssessFightSound assumes ZS_ProclaimAndPunish to also work for NPC offenders.

It seems that ZS_ProclaimAndPunish is fully reserved for reactions towards the player. Starting the state ZS_ProclaimAndPunish in B_AssessFightSound should be replaced by starting the state ZS_Attack (if the player is the victim not the offender).

Skript: ### Gorn(5) ### -> B_AssessFightSound .... <zError.cpp,#462>
Skript: ### Gorn(5) ### -> C_NpcIsHuman .... <zError.cpp,#462>
Skript: ### Gorn(5) ### -> ...name: Me .... <zError.cpp,#462>
Skript: ### Gorn(5) ### -> ...true .... <zError.cpp,#462>
Skript: ### Gorn(5) ### -> C_NpcIsMonster .... <zError.cpp,#462>
Skript: ### Gorn(5) ### -> ...name: Guard .... <zError.cpp,#462>
Skript: ### Gorn(5) ### -> ...false .... <zError.cpp,#462>
Skript: ### Gorn(5) ### -> C_NpcIsHuman .... <zError.cpp,#462>
Skript: ### Gorn(5) ### -> ...name: Guard .... <zError.cpp,#462>
Skript: ### Gorn(5) ### -> ...true .... <zError.cpp,#462>
Skript: ### Gorn(5) ### -> C_NpcIsMonster .... <zError.cpp,#462>
Skript: ### Gorn(5) ### -> ...name: Me .... <zError.cpp,#462>
Skript: ### Gorn(5) ### -> ...false .... <zError.cpp,#462>
Skript: ### Gorn(5) ### -> C_ChargeWasAttacked .... <zError.cpp,#462>
Skript: ### Gorn(5) ### -> C_NpcIsGuardArcher .... <zError.cpp,#462>
Skript: ### Gorn(5) ### -> ...false! .... <zError.cpp,#462>
Skript: ### Gorn(5) ### -> C_NpcIsGuard .... <zError.cpp,#462>
Skript: ### Gorn(5) ### -> ...true! .... <zError.cpp,#462>
Skript: ### Gorn(5) ### -> ...NSC ist Wache oder FK-Wache! .... <zError.cpp,#462>
Skript: ### Gorn(5) ### -> ...true .... <zError.cpp,#462>
Skript: ### Gorn(5) ### -> ...NSC ist Wache und ein Schützling wurde attackiert! .... <zError.cpp,#462>
Skript: ### Gorn(5) ### -> PrintGlobals .... <zError.cpp,#462>
Skript: ### Gorn(5) ### -> ...self:   Gorn .... <zError.cpp,#462>
Skript: ### Gorn(5) ### -> ...other:  Guard .... <zError.cpp,#462>
Skript: ### Gorn(5) ### -> ...victim: Me .... <zError.cpp,#462>
Skript: ### Gorn(5) ### -> ...hero:   Me .... <zError.cpp,#462>
Skript: ### Gorn(5) ### -> ...und der ist auch sauer bzw. flieht! .... <zError.cpp,#462>

[AmProsius]