Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shrike's Hut quest #33

Closed
AmProsius opened this issue Jan 4, 2021 · 2 comments · Fixed by #153
Closed

Shrike's Hut quest #33

AmProsius opened this issue Jan 4, 2021 · 2 comments · Fixed by #153
Labels
compatibility: easy This issue is easy to make compatible. impl: hook script func This issue requires hooking script functions. provided fix This issue has a fix provided in the comments. type: session fix The fix for this issues is persistent across a session.
Milestone

Comments

@AmProsius
Copy link
Owner

AmProsius commented Jan 4, 2021

Describe the bug

  • Gorn can be told about Shrike's defeat even if the player doesn't know about the hut.
  • The quest "Shrike's Hut" can't be closed if the player defeats Shrike without knowing from Gorn about the hut.

Expected behavior
The quest "Shrike's Hut" can be closed no matter in which order the player gets to know about the quest and defeats Shrike.

Additional context
German translation of the quest is Shrike's Hütte.

@AmProsius AmProsius added this to To Do in v1.0.0 via automation Jan 4, 2021
@AmProsius AmProsius removed this from To Do in v1.0.0 Feb 9, 2021
@catalinstoian
Copy link

catalinstoian commented Feb 13, 2021

FUNC int DIA_Gorn_HutFree_Condition()
{
if (Npc_KnowsInfo(hero, DIA_Shrike_GetLost))
{
return 1;
};
};

changed to

FUNC int DIA_Gorn_HutFree_Condition()
{
	if (Npc_KnowsInfo(hero,DIA_Gorn_Hut)) && (Npc_KnowsInfo(hero, DIA_Shrike_GetLost))
	{
		return 1;
	};
};

@szapp szapp added compatibility: easy This issue is easy to make compatible. type: session fix The fix for this issues is persistent across a session. labels Feb 13, 2021
@AmProsius AmProsius added the provided fix This issue has a fix provided in the comments. label Feb 13, 2021
@AmProsius AmProsius added this to To Do in v1.0.0 Feb 13, 2021
@AmProsius AmProsius added this to the v1.0.0 milestone Feb 13, 2021
@AmProsius AmProsius added the validation: required This issue needs validation from one of the validators. label Feb 20, 2021
@szapp
Copy link
Collaborator

szapp commented Feb 26, 2021

I will also check whether the quest about Shrike is running (compare to DIA_Gorn_Hut), such that either the quest has to be running, or the dialog was told.

FUNC int DIA_Gorn_HutFree_Condition() 
{
    if ((Gorn_ShrikesHut == LOG_RUNNING) || (Npc_KnowsInfo(hero, DIA_Gorn_Hut))) && (Npc_KnowsInfo(hero, DIA_Shrike_GetLost))
	{
		return 1;
	};
};

@szapp szapp moved this from To Do to In Progress in v1.0.0 Feb 27, 2021
@szapp szapp moved this from In Progress to To Do in v1.0.0 Mar 3, 2021
@AmProsius AmProsius added this to Info condition in Fix templates Mar 4, 2021
@szapp szapp moved this from To Do to In Progress in v1.0.0 Mar 4, 2021
szapp added a commit that referenced this issue Mar 4, 2021
v1.0.0 automation moved this from In Progress to Done Mar 4, 2021
AmProsius added a commit that referenced this issue Mar 4, 2021
#33: Fix Gorn's dialog about Shrike's quest
@szapp szapp added the impl: hook script func This issue requires hooking script functions. label Mar 16, 2021
@szapp szapp moved this from Hook Daedalus function to Unsorted in Fix templates Mar 16, 2021
@szapp szapp moved this from Unsorted to Dialog: Info condition in Fix templates Mar 17, 2021
AmProsius added a commit that referenced this issue Apr 15, 2021
@szapp szapp removed the validation: required This issue needs validation from one of the validators. label May 14, 2021
AmProsius added a commit that referenced this issue May 14, 2021
szapp added a commit that referenced this issue May 15, 2021
The quest should not be set to running, but to be explicitly not running.
@szapp szapp moved this from Modify dialog conditions to Add dialog conditions in Fix templates Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility: easy This issue is easy to make compatible. impl: hook script func This issue requires hooking script functions. provided fix This issue has a fix provided in the comments. type: session fix The fix for this issues is persistent across a session.
Projects
Fix templates
Add dialog conditions
v1.0.0
  
Done
Development

Successfully merging a pull request may close this issue.

3 participants