Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Snaf's Nek dialog disappears #38

Closed
AmProsius opened this issue Jan 6, 2021 · 1 comment · Fixed by #96
Closed

Snaf's Nek dialog disappears #38

AmProsius opened this issue Jan 6, 2021 · 1 comment · Fixed by #96
Labels
compatibility: easy This issue is easy to make compatible. impl: hook script func This issue requires hooking script functions. type: session fix The fix for this issues is persistent across a session.
Projects
v1.0.0 Fix templates
Milestone
v1.0.0

Comments

@AmProsius
Copy link
Owner

Snaf can't be asked about Nek if the quest "Snaf's Recipe" is closed.
@AmProsius AmProsius added this to To Do in v1.0.0 via automation Jan 6, 2021
@catalinstoian
Copy link

catalinstoian commented Jan 16, 2021 •
edited by szapp

gothic-1-community-patch/scriptbase/_work/Data/Scripts/Content/Story/Missions/DIA_VLK_581_Snaf.d

Lines 288 to 294 in e66b303

FUNC INT DIA_Snaf_WhereNek_Condition()
{
if ( (Snaf_Zutaten==LOG_RUNNING) )
{
return 1;
};
};

changed to

FUNC INT DIA_Snaf_WhereNek_Condition()
{	
	if ( (Snaf_Zutaten==LOG_RUNNING) || (Snaf_Zutaten==LOG_SUCCESS) )
	{
		return 1;
	};
};

@szapp szapp added type: session fix The fix for this issues is persistent across a session. compatibility: easy This issue is easy to make compatible. labels Jan 24, 2021
szapp added a commit that referenced this issue Feb 1, 2021
@szapp
#38: Snaf now correctly offers the Nek dialog
ed9128c
szapp added a commit that referenced this issue Feb 1, 2021
@szapp
Add #38 to the changelog
bdb560b
@szapp szapp mentioned this issue Feb 1, 2021
Merged
AmProsius added a commit that referenced this issue Feb 1, 2021
@AmProsius
Added German text for #38
69eeab7
v1.0.0 automation moved this from To Do to Done Feb 1, 2021
AmProsius added a commit that referenced this issue Feb 1, 2021
@AmProsius
Merge pull request #96 from AmProsius/bug038
2c8b731 
#38: Snaf now correctly offers the Nek dialog
@AmProsius AmProsius added this to the v1.0.0 milestone Feb 9, 2021
@szapp szapp added this to Info condition (hook) in Fix templates Mar 15, 2021
@szapp szapp added the impl: hook script func This issue requires hooking script functions. label Mar 16, 2021
@szapp szapp moved this from Hook Daedalus function to Unsorted in Fix templates Mar 16, 2021
@szapp szapp moved this from Unsorted to Dialog: Info condition in Fix templates Mar 17, 2021
AmProsius added a commit that referenced this issue Apr 19, 2021
@AmProsius
refactor: simplify test of #38
1ffe917
@szapp szapp moved this from Modify dialog conditions to Add dialog conditions in Fix templates Feb 6, 2022
@AmProsius AmProsius mentioned this issue Apr 24, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compatibility: easy This issue is easy to make compatible. impl: hook script func This issue requires hooking script functions. type: session fix The fix for this issues is persistent across a session.
Projects
Fix templates
Add dialog conditions
v1.0.0
  
Done
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

#38: Snaf now correctly offers the Nek dialog AmProsius/gothic-1-community-patch
3 participants
@AmProsius @catalinstoian @szapp