Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aleph's key dialog doesn't disappear #40

Open
AmProsius opened this issue Jan 6, 2021 · 2 comments · Fixed by #97
Open

Aleph's key dialog doesn't disappear #40

AmProsius opened this issue Jan 6, 2021 · 2 comments · Fixed by #97
Assignees
Labels
compatibility: difficult This issue is difficult to make compatible. impl: add/modify if-condition This issue requires adding/replacing conditions to if-statements. impl: change obj var This issue requires changing properties of objects. impl: hook script func This issue requires hooking script functions. provided fix This issue has a fix provided in the comments. type: revert on save The fix for this issue impacts the game and should be reverted when saving.
Milestone

Comments

@AmProsius
Copy link
Owner

Aleph still offers to sell the key for the chests in the storage shed even if the player has already obtained the key.

@AmProsius AmProsius added this to To Do in v1.0.0 via automation Jan 6, 2021
@catalinstoian
Copy link

catalinstoian commented Jan 16, 2021

FUNC int VLK_585_Aleph_DIRTY_Condition()
{
if ( Npc_KnowsInfo (hero, GRD_271_ULBERT_DRUNK) ) && ( Npc_KnowsInfo (hero, GRD_261_Brandick_ALEPH) )
{
return 1;
};
};

changed to

FUNC int  VLK_585_Aleph_DIRTY_Condition()
{
	if ( Npc_KnowsInfo (hero, GRD_271_ULBERT_DRUNK) ) && ( Npc_KnowsInfo (hero, GRD_261_Brandick_ALEPH) ) && ( !Npc_KnowsInfo (hero, VLK_585_Aleph_SCHUPPEN) )
	{
		return 1;
	};
};

@szapp szapp added the type: session fix The fix for this issues is persistent across a session. label Jan 24, 2021
@szapp szapp added the compatibility: easy This issue is easy to make compatible. label Jan 31, 2021
szapp added a commit that referenced this issue Feb 1, 2021
v1.0.0 automation moved this from To Do to Done Feb 2, 2021
AmProsius added a commit that referenced this issue Feb 2, 2021
#40: Aleph does not offer the keys again
@AmProsius AmProsius added this to the v1.0.0 milestone Feb 9, 2021
@szapp szapp added this to Info condition (hook) in Fix templates Mar 15, 2021
@szapp szapp added the impl: hook script func This issue requires hooking script functions. label Mar 16, 2021
@szapp szapp moved this from Hook Daedalus function to Unsorted in Fix templates Mar 16, 2021
@szapp szapp moved this from Unsorted to Dialog: Info condition in Fix templates Mar 17, 2021
AmProsius added a commit that referenced this issue Apr 19, 2021
@AmProsius
Copy link
Owner Author

The fix should be changed as suggested in #189 .

@AmProsius AmProsius reopened this Oct 30, 2021
@AmProsius AmProsius added this to To Do in v1.3.0 via automation Oct 30, 2021
@AmProsius AmProsius modified the milestones: v1.0.0, v1.3.0 Oct 30, 2021
@szapp szapp added compatibility: difficult This issue is difficult to make compatible. impl: add/modify if-condition This issue requires adding/replacing conditions to if-statements. and removed type: session fix The fix for this issues is persistent across a session. compatibility: easy This issue is easy to make compatible. impl: hook script func This issue requires hooking script functions. labels Feb 6, 2022
@szapp szapp added impl: change obj var This issue requires changing properties of objects. provided fix This issue has a fix provided in the comments. type: revert on save The fix for this issue impacts the game and should be reverted when saving. impl: hook script func This issue requires hooking script functions. labels Feb 6, 2022
@szapp szapp moved this from Modify dialog conditions to Add dialog conditions in Fix templates Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility: difficult This issue is difficult to make compatible. impl: add/modify if-condition This issue requires adding/replacing conditions to if-statements. impl: change obj var This issue requires changing properties of objects. impl: hook script func This issue requires hooking script functions. provided fix This issue has a fix provided in the comments. type: revert on save The fix for this issue impacts the game and should be reverted when saving.
Projects
Fix templates
Add dialog conditions
v1.3.0
  
To Do
v1.0.0
  
Done
Development

Successfully merging a pull request may close this issue.

3 participants