New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Guard has duplicated END dialog #42
Labels
compatibility: easy
This issue is easy to make compatible.
impl: hook script func
This issue requires hooking script functions.
impl: modify/analyze script func
This issue requires analyzing and/or modifying the bytecode of script functions.
provided fix
This issue has a fix provided in the comments.
type: session fix
The fix for this issues is persistent across a session.
Projects
Milestone
Comments
Lines 5 to 23 in e66b303
changed to /*
instance DIA_Grd_218_Exit (C_INFO)
{
npc = Grd_218_GArdist;
nr = 999;
condition = DIA_Grd_218_Exit_Condition;
information = DIA_Grd_218_Exit_Info;
permanent = 1;
description = DIALOG_ENDE;
};
FUNC int DIA_Grd_218_Exit_Condition()
{
return 1;
};
FUNC VOID DIA_Grd_218_Exit_Info()
{
AI_StopProcessInfos (self);
};
*/ and Lines 5 to 23 in e66b303
changed to /*
instance DIA_GRD_245_Exit (C_INFO)
{
npc = GRD_245_Gardist;
nr = 999;
condition = DIA_GRD_245_Exit_Condition;
information = DIA_GRD_245_Exit_Info;
permanent = 1;
description = DIALOG_ENDE;
};
FUNC int DIA_GRD_245_Exit_Condition()
{
return 1;
};
FUNC VOID DIA_GRD_245_Exit_Info()
{
AI_StopProcessInfos (self);
};
*/ |
szapp
added
the
type: revert on save
The fix for this issue impacts the game and should be reverted when saving.
label
Jan 24, 2021
AmProsius
changed the title
Gardist guards have duplicated END dialog
Guards have duplicated END dialog
Jan 25, 2021
szapp
added
compatibility: difficult
This issue is difficult to make compatible.
compatibility: easy
This issue is easy to make compatible.
type: session fix
The fix for this issues is persistent across a session.
and removed
compatibility: difficult
This issue is difficult to make compatible.
type: revert on save
The fix for this issue impacts the game and should be reverted when saving.
labels
Feb 9, 2021
szapp
added a commit
that referenced
this issue
Feb 12, 2021
AmProsius
added a commit
that referenced
this issue
Feb 13, 2021
#42: Remove duplicate EXIT dialog from guards
szapp
added a commit
that referenced
this issue
Mar 13, 2021
Check if there is ANY exit dialog not only the known ones
szapp
added
impl: hook script func
This issue requires hooking script functions.
impl: modify/analyze script func
This issue requires analyzing and/or modifying the bytecode of script functions.
labels
Mar 16, 2021
szapp
added a commit
that referenced
this issue
Mar 17, 2021
AmProsius
added a commit
that referenced
this issue
Apr 19, 2021
This issue was split into two separate issues (see #244). |
AmProsius
added a commit
that referenced
this issue
Jul 22, 2021
AmProsius
changed the title
Guards have duplicated END dialog
Guard has duplicated END dialog
Jul 22, 2021
AmProsius
added a commit
that referenced
this issue
Jul 27, 2021
AmProsius
added a commit
that referenced
this issue
Jul 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
compatibility: easy
This issue is easy to make compatible.
impl: hook script func
This issue requires hooking script functions.
impl: modify/analyze script func
This issue requires analyzing and/or modifying the bytecode of script functions.
provided fix
This issue has a fix provided in the comments.
type: session fix
The fix for this issues is persistent across a session.
Describe the bug
One of the guards guarding the ore barons' house in the Old Camp has two END dialog options.
Expected behavior
One of the guards guarding the ore barons' house in the Old Camp no longer has two END dialog options.
Additional context
The NPC is
GRD_218_Gardist
. This issue split two separate issues, the other one being #244.The text was updated successfully, but these errors were encountered: