Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugmeat in the wrong inventory category #44

Closed
AmProsius opened this issue Jan 6, 2021 · 2 comments · Fixed by #155
Closed

Bugmeat in the wrong inventory category #44

AmProsius opened this issue Jan 6, 2021 · 2 comments · Fixed by #155
Labels
compatibility: easy This issue is easy to make compatible. impl: replace assign int This issue requires replacing integer assignments in the scripts. provided fix This issue has a fix provided in the comments. type: session fix The fix for this issues is persistent across a session. validation: validated This issue is still present even with Systempack/Union.
Projects
v1.0.0 Fix templates
Milestone
v1.0.0

Comments

@AmProsius
Copy link
Owner

Bugmeat should be in the category FOOD.
@AmProsius AmProsius added this to To Do in v1.0.0 via automation Jan 6, 2021
@AmProsius AmProsius added validation: required This issue needs validation from one of the validators. validation: validated This issue is still present even with Systempack/Union. and removed validation: required This issue needs validation from one of the validators. labels Jan 28, 2021
@AmProsius
Copy link
Owner Author

gothic-1-community-patch/scriptbase/_work/Data/Scripts/Content/Items/Food.d

Lines 59 to 63 in a8d2602

INSTANCE ItAt_Meatbug_01 (C_Item)
{
name = "Bugmeat";
mainflag = ITEM_KAT_NONE;

changed to

INSTANCE ItAt_Meatbug_01 (C_Item)
{
    name                =   "Bugmeat";

    mainflag            =   ITEM_KAT_FOOD;

@AmProsius AmProsius removed this from To Do in v1.0.0 Feb 9, 2021
@AmProsius AmProsius added the provided fix This issue has a fix provided in the comments. label Feb 11, 2021
@AmProsius AmProsius added this to To Do in v1.0.0 Feb 13, 2021
@AmProsius AmProsius added this to the v1.0.0 milestone Feb 13, 2021
@szapp szapp added compatibility: easy This issue is easy to make compatible. type: session fix The fix for this issues is persistent across a session. labels Feb 13, 2021
@szapp
Copy link
Collaborator

szapp commented Feb 13, 2021

This fix will be very similar to #49 and might be fast to implement.

This was referenced Feb 13, 2021
Closed
Closed
@szapp szapp moved this from To Do to In Progress in v1.0.0 Feb 27, 2021
szapp added a commit that referenced this issue Feb 27, 2021
@szapp
#44: List bug meat as food
390cee9
@szapp szapp mentioned this issue Feb 27, 2021
Merged
@AmProsius AmProsius added this to Item property in Fix templates Mar 1, 2021
v1.0.0 automation moved this from In Progress to Done Mar 3, 2021
AmProsius added a commit that referenced this issue Mar 3, 2021
@AmProsius
Merge pull request #155 from AmProsius/bug044
f79b6d5 
#44: List bug meat as food
@szapp szapp moved this from Instance variable (string) to Instance variable (int) in Fix templates Mar 3, 2021
szapp added a commit that referenced this issue Mar 13, 2021
@szapp
Simplify #12 #28 #44 #125 with GetIntVar
6721b44
@szapp szapp added impl: modify/analyze script func This issue requires analyzing and/or modifying the bytecode of script functions. impl: replace assign int This issue requires replacing integer assignments in the scripts. and removed impl: modify/analyze script func This issue requires analyzing and/or modifying the bytecode of script functions. labels Mar 17, 2021
AmProsius added a commit that referenced this issue Apr 19, 2021
@AmProsius
refactor: simplify test of #44
c4dc6d6
szapp added a commit that referenced this issue Apr 19, 2021
@szapp
fix: avoid using global symbol names as local names
5460b48 
Refs #44 #49
@szapp szapp moved this from Instance variable (int) to Item instance variable (int) in Fix templates Feb 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compatibility: easy This issue is easy to make compatible. impl: replace assign int This issue requires replacing integer assignments in the scripts. provided fix This issue has a fix provided in the comments. type: session fix The fix for this issues is persistent across a session. validation: validated This issue is still present even with Systempack/Union.
Projects
Fix templates
Change item instance variable (int)
v1.0.0
  
Done
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

#44: List bug meat as food AmProsius/gothic-1-community-patch
2 participants
@AmProsius @szapp