Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dungeon Key description faulty #49

Closed
AmProsius opened this issue Jan 6, 2021 · 6 comments · Fixed by #106
Closed

Dungeon Key description faulty #49

AmProsius opened this issue Jan 6, 2021 · 6 comments · Fixed by #106
Labels
impl: modify/analyze script func This issue requires analyzing and/or modifying the bytecode of script functions. type: session fix The fix for this issues is persistent across a session.
Milestone

Comments

@AmProsius
Copy link
Owner

"des Alten Lagers" from Dungeon Key should be translated to English.

@AmProsius AmProsius added validation required language dependent This issue only occurs in certain localizations. labels Jan 6, 2021
@AmProsius AmProsius added this to To Do in v1.0.0 via automation Jan 6, 2021
@szapp
Copy link
Collaborator

szapp commented Jan 31, 2021

It seems like this issue is already fixed in the scripts we have (see below). Does it exist in the English retail version of the game?

If there are versions of the game that contain this incorrect description, we can verify it and if necessary correct it. I can't hurt - but we could save some time if it turns out, it's not necessary to fix.

//---------------------------------------------------------------------
// Kerkerschlüssel
//---------------------------------------------------------------------
INSTANCE DungeonKey(C_Item)
{
name = "Dungeon Key";
mainflag = ITEM_KAT_NONE;
flags = ITEM_MISSION;
value = 3;
visual = "ItKe_Key_03.3ds";
material = MAT_METAL;
description = name;
TEXT[0] = "Opens the dungeons";
TEXT[0] = "of the old camp.";
};

@szapp
Copy link
Collaborator

szapp commented Jan 31, 2021

This very fix is actually mentioned in the release of the scripts we are using. I don't quite understand, if that was just a bug in the mod-kit scripts and the complied scripts were already correct.

If someone has access to a retail version of the game we could confirm it.

Nevertheless, if in doubt, we might as well just go ahead and add a fix that replaces the text given it is wrong.

@AmProsius AmProsius added the validation: validated This issue is still present even with Systempack/Union. label Feb 1, 2021
@AmProsius
Copy link
Owner Author

AmProsius commented Feb 1, 2021

I extracted the gothic.dat file of the English version from GOG with DecDat and the issue seems fixed there:

instance dungeonkey(c_item) {
    name = "Dungeon Key";
    mainflag = item_kat_none;
    flags = item_mission;
    value = 3;
    visual = "ItKe_Key_03.3ds";
    material = mat_metal;
    description = name;
    text = "Opens the dungeons";
    text = "of the old camp.";
};

I will close this issue then as the missing translation is not present in the current retail version of the game.

v1.0.0 automation moved this from To Do to Done Feb 1, 2021
@AmProsius AmProsius removed the validation: validated This issue is still present even with Systempack/Union. label Feb 1, 2021
@AmProsius
Copy link
Owner Author

This is the actual fix:

description = name;
TEXT[0] = "Opens the dungeons";
TEXT[0] = "of the old camp.";

changed to

     description         = name; 
     TEXT[0]             = "Opens the dungeons"; 
     TEXT[1]             = "of the old camp."; 

@AmProsius AmProsius changed the title Dungeon Key label contains not translated phrase Dungeon Key description faulty Feb 1, 2021
@AmProsius AmProsius reopened this Feb 1, 2021
v1.0.0 automation moved this from Done to In Progress Feb 1, 2021
@szapp szapp added the type: session fix The fix for this issues is persistent across a session. label Feb 1, 2021
@szapp
Copy link
Collaborator

szapp commented Feb 1, 2021

Could someone confirm if this is still a language dependent bug, or the scripts look the same in the German localization?

@AmProsius AmProsius removed the language dependent This issue only occurs in certain localizations. label Feb 4, 2021
@AmProsius
Copy link
Owner Author

AmProsius commented Feb 4, 2021

The bug is also present in the German scripts:

	description			= name;
	TEXT[0]				= "öffnet den Kerker";
	TEXT[0]				= "des Alten Lagers.";

ScreenShot_2021_2_4_23_43_59

szapp added a commit that referenced this issue Feb 9, 2021
The fix is language independent, but the test is (EN/DE)
v1.0.0 automation moved this from In Progress to Done Feb 9, 2021
AmProsius added a commit that referenced this issue Feb 9, 2021
#49: Fix the item text of the dungeon key
@AmProsius AmProsius added this to the v1.0.0 milestone Feb 9, 2021
@AmProsius AmProsius added this to Item property in Fix templates Mar 1, 2021
@szapp szapp added the impl: replace assign/push str This issue requires replacing pushed strings or string assignments in the scripts. label Mar 17, 2021
@szapp szapp added impl: modify/analyze script func This issue requires analyzing and/or modifying the bytecode of script functions. and removed impl: replace assign/push str This issue requires replacing pushed strings or string assignments in the scripts. labels Mar 17, 2021
AmProsius added a commit that referenced this issue Apr 19, 2021
@szapp szapp moved this from Instance variable (string) to Item instance variable (string) in Fix templates Feb 5, 2022
@szapp szapp moved this from Item instance variable (string) to Instance variable (string) in Fix templates Feb 5, 2022
@szapp szapp moved this from Instance variable (string) to Item instance variable (string) in Fix templates Feb 5, 2022
@AmProsius AmProsius reopened this Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impl: modify/analyze script func This issue requires analyzing and/or modifying the bytecode of script functions. type: session fix The fix for this issues is persistent across a session.
Projects
Fix templates
Change item instance variable (string)
v1.0.0
  
Done
Development

Successfully merging a pull request may close this issue.

2 participants