New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exploit: Grindstone in the New Camp can be used without sword blade #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AmProsius
added
the
type: world bug
This issue requires editing properties of objects in the game world.
label
Jan 9, 2021
AmProsius
added
the
validation: required
This issue needs validation from one of the validators.
label
Jan 28, 2021
|
AmProsius
changed the title
Mobs in New Camp can't be used
Mobs in New Camp can be used without corresponding items
Feb 4, 2021
AmProsius
changed the title
Mobs in New Camp can be used without corresponding items
MOBs in New Camp can be used without corresponding items
Feb 12, 2021
AmProsius
added
provided fix
This issue has a fix provided in the comments.
validation: validated
This issue is still present even with Systempack/Union.
and removed
validation: required
This issue needs validation from one of the validators.
labels
Feb 12, 2021
szapp
added
compatibility: easy
This issue is easy to make compatible.
type: revert on save
The fix for this issue impacts the game and should be reverted when saving.
labels
Feb 13, 2021
szapp
removed
the
type: revert on save
The fix for this issue impacts the game and should be reverted when saving.
label
Mar 1, 2021
szapp
added
impl: unknown
There is no clear plan on how to implement this issue yet.
impl: change obj var
This issue requires changing properties of objects.
and removed
impl: unknown
There is no clear plan on how to implement this issue yet.
labels
Mar 17, 2021
This was referenced Mar 28, 2021
szapp
changed the title
MOBs in New Camp can be used without corresponding items
Grindstone in the New Camp can be used without sword blade
Mar 28, 2021
The test is manual. The player is teleported to the grindstone and should no longer be able to use it without a sword blade. What I have not tested yet, is that this change is reverted properly. |
AmProsius
changed the title
Grindstone in the New Camp can be used without sword blade
Exploit: Grindstone in the New Camp can be used without sword blade
Mar 28, 2021
AmProsius
reviewed
Mar 28, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fix is reverted correctly when removing the patch.
AmProsius
added a commit
that referenced
this pull request
Apr 20, 2021
szapp
added a commit
that referenced
this pull request
Jan 18, 2022
Finding VOBs by their exact position can now be further narrowed down by their class. Like before only the first matching VOB will be found. The function can now also detect light VOBs which where previously ignored. For details, see the header commment of ent of 'G1CP_FindVobByPosPtr'. Common class definitions are defined as constants in constants.d. All affected fixes are updated. Refs #46 #51 #52 #127 #212 #213 #226
szapp
added a commit
that referenced
this pull request
Jan 19, 2022
Instead of specifying a class to narrow down the search (see previous commit), the option is now more versatile: Now the last parameter is a callback function. It can either be one of the existing class check functions or a custom function to narrow down the search more flexibly and potentially based on more or more complex checks. Refs #46 #51 #52 #127 #212 #213 #226
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
compatibility: easy
This issue is easy to make compatible.
impl: change obj var
This issue requires changing properties of objects.
provided fix
This issue has a fix provided in the comments.
type: world bug
This issue requires editing properties of objects in the game world.
validation: validated
This issue is still present even with Systempack/Union.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the bug
The grindstone in the New Camp can be used without having a sword blade in the inventory.
Expected behavior
The grindstone in the New Camp now correctly requires a sword blade to use.
Additional context
It's currently possible to produce Grobe Schwerter without having Swordblades in the inventory.
This issue was split into two further issues #212 #213.
Add
useWithItem
withItMiSwordblade
to grindstone atNC_HUT03_OUT_MOVEMENT
.Screenhots