Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misplaced texture near Gravo #57

Merged
merged 4 commits into from Jan 27, 2022
Merged

Misplaced texture near Gravo #57

merged 4 commits into from Jan 27, 2022

Conversation

AmProsius
Copy link
Owner

There's a misplaced texture near Gravo at the water.

@AmProsius AmProsius added this to To Do in v1.0.0 via automation Jan 6, 2021
@AmProsius
Copy link
Owner Author

This issue was fixed in freddy's world patch.

@AmProsius AmProsius added the type: world bug This issue requires editing properties of objects in the game world. label Jan 9, 2021
@AmProsius AmProsius removed this from To Do in v1.0.0 Jan 9, 2021
@szapp
Copy link
Collaborator

szapp commented Jan 24, 2021

If possible, could you make a screenshot (before/after) and supply the nearest waypoint (console: toggle waynet). That would allow to check whether this fix could be handled scriptwise.

@AmProsius
Copy link
Owner Author

There's a flickering texture edge at OCR_LAKE_3 if you look at the sewer.

057

@szapp
Copy link
Collaborator

szapp commented Jan 25, 2021

Thanks for the screenshot (even with the waypoint!). I never noticed this issue. Do you know if it requires adjustments to the polygons or can it be fixed by just replacing the texture?

@AmProsius
Copy link
Owner Author

Unfortunately I don't know. I just saw that freddy fixed this in his world patch. I even don't know if freddy is still around.

@AmProsius AmProsius added validation: required This issue needs validation from one of the validators. validation: validated This issue is still present even with Systempack/Union. and removed validation: required This issue needs validation from one of the validators. labels Jan 28, 2021
@szapp szapp added the type: revert on save The fix for this issue impacts the game and should be reverted when saving. label Feb 13, 2021
@szapp szapp removed the type: revert on save The fix for this issue impacts the game and should be reverted when saving. label Mar 1, 2021
@szapp szapp self-assigned this Mar 19, 2021
@szapp szapp added this to Other in Fix templates Apr 5, 2021
@N1kX94
Copy link

N1kX94 commented Apr 6, 2021

There is a decal vob.
image

		[% zCVob 12289 4428]
			pack=int:0
			presetName=string:
			bbox3DWS=rawFloat:-6037.74023 -973.349243 -231.117416 -5750.08887 -355.191528 388.98526 
			trafoOSToWSRot=raw:6437b5be8fedc93d3d186e3f472e1f3bf4987e3fee07d6bd926d6fbf27410ebda058b4be
			trafoOSToWSPos=vec3:-5893.91455 -664.270386 78.9339142
			vobName=string:
			visual=string:OW_DIRTDECAL.TGA
			showVisual=bool:1
			visualCamAlign=enum:0
			cdStatic=bool:0
			cdDyn=bool:0
			staticVob=bool:0
			dynShadow=enum:0
			[visual zCDecal 0 4429]
				name=string:OW_DIRTDECAL.TGA
				decalDim=rawFloat:320 310 
				decalOffset=rawFloat:0 0 
				decal2Sided=bool:0
				decalAlphaFunc=enum:3
				decalTexAniFPS=float:0
			[]
			[ai % 0 0]
			[]
		[]

It can be moved to these coordinates, then it will look normal as it is now.
trafoOSToWSPos=vec3:-5902.01807 -664.270386 82.8507462

Before
image

after
image

But as I noticed in the patch topic, in Gothic 1, the vob class does not have a parameter VobFarClipZScale for adjusting the rendering range, so all these decal vobs flicker at a distance.
Solution don't know, delete if only...

@AmProsius AmProsius added compatibility: easy This issue is easy to make compatible. provided fix This issue has a fix provided in the comments. impl: change obj var This issue requires changing properties of objects. labels Apr 6, 2021
@szapp szapp moved this from Other to VOB property in Fix templates Apr 7, 2021
@szapp szapp removed their assignment Apr 7, 2021
@szapp szapp added this to the v1.2.0 milestone Apr 22, 2021
@szapp szapp added this to To Do in v1.2.0 via automation Apr 22, 2021
@AmProsius AmProsius self-assigned this May 7, 2021
@szapp
Copy link
Collaborator

szapp commented May 13, 2021

Note: Again G1CP_FindVobByPosF will be useful. Unlike the related issues (e.g. #52 #127 #212 #213 to name a few), however, there is no Hlp_Is_... function for zCDecal objects. This could possibly be emulated with:

if (vobPtr) {
    const int zCDecal_vtbl = 8207876; //0x7D3E04
    if (MEM_ReadInt(vobPtr) == zCDecal_vtbl) {
        // Valid
    };
};

@AmProsius AmProsius moved this from To Do to In Progress in v1.2.0 Jul 31, 2021
@AmProsius AmProsius marked this pull request as draft August 12, 2021 11:57
@AmProsius AmProsius assigned szapp and unassigned AmProsius Oct 11, 2021
@AmProsius AmProsius added this to In Progress in v1.3.0 via automation Oct 30, 2021
@AmProsius AmProsius removed this from In Progress in v1.2.0 Oct 30, 2021
@AmProsius AmProsius modified the milestones: v1.2.0, v1.3.0 Oct 30, 2021
@szapp szapp removed their assignment Jan 19, 2022
@szapp
Copy link
Collaborator

szapp commented Jan 19, 2022

@AmProsius This PR should be done too. Here, too, I have not tested whether the texture is back at its original positing when unloading the patch.

@szapp szapp marked this pull request as ready for review January 19, 2022 00:42
@AmProsius AmProsius merged commit 53bee81 into master Jan 27, 2022
@AmProsius AmProsius deleted the bug057 branch January 27, 2022 19:34
v1.3.0 automation moved this from In Progress to Done Jan 27, 2022
@AmProsius
Copy link
Owner Author

When starting the game (again) without the patch, the flickering texture is back.

@AmProsius AmProsius moved this from Change VOB property to Change VOB location in Fix templates Jan 14, 2023
AmProsius pushed a commit that referenced this pull request Jan 14, 2023
AmProsius pushed a commit that referenced this pull request Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility: easy This issue is easy to make compatible. impl: change obj var This issue requires changing properties of objects. provided fix This issue has a fix provided in the comments. type: world bug This issue requires editing properties of objects in the game world. validation: validated This issue is still present even with Systempack/Union.
Projects
Fix templates
Change VOB location
v1.3.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants