Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jesse's quest not available #60

Closed
AmProsius opened this issue Jan 9, 2021 · 1 comment · Fixed by #100
Closed

Jesse's quest not available #60

AmProsius opened this issue Jan 9, 2021 · 1 comment · Fixed by #100
Labels
compatibility: easy This issue is easy to make compatible. impl: modify/analyze script func This issue requires analyzing and/or modifying the bytecode of script functions. type: session fix The fix for this issues is persistent across a session.
Projects
v1.0.0 Fix templates
Milestone
v1.0.0

Comments

@AmProsius
Copy link
Owner

Jesse's quest PayForMe is not available due to a bug.
@AmProsius AmProsius added this to To Do in v1.0.0 via automation Jan 9, 2021
@catalinstoian
Copy link

catalinstoian commented Jan 24, 2021 •
edited by AmProsius

gothic-1-community-patch/scriptbase/_work/Data/Scripts/Content/Story/Missions/DIA_VLK_564_Jesse.d

Lines 102 to 108 in e66b303

FUNC INT DIA_Jesse_Mission_Condition()
{
if (Npc_KnowsInfo(hero,DIA_Jesse_Mission))
{
return 1;
};
};

changed to

FUNC INT DIA_Jesse_Mission_Condition()
{	
	if (Npc_KnowsInfo(hero,DIA_Jesse_Warn))
	{
		return 1;
	};
};

@szapp szapp added the type: session fix The fix for this issues is persistent across a session. label Jan 24, 2021
@szapp szapp added the compatibility: easy This issue is easy to make compatible. label Jan 31, 2021
szapp added a commit that referenced this issue Feb 2, 2021
@szapp
#60: Fix Jesse's quest
ead64be
@szapp szapp mentioned this issue Feb 2, 2021
Merged
v1.0.0 automation moved this from To Do to Done Feb 2, 2021
AmProsius added a commit that referenced this issue Feb 2, 2021
@AmProsius
Merge pull request #100 from AmProsius/bug060
3498c8f 
#60: Fix Jesse's quest
szapp added a commit that referenced this issue Feb 7, 2021
@szapp
Make fix condition of #60 more tight
7147bfa 
Avoid reverting the fix if it was already applied by someone else
@AmProsius AmProsius added this to the v1.0.0 milestone Feb 9, 2021
szapp added a commit that referenced this issue Mar 13, 2021
@szapp
Check variable content in #60 and #79
f8d2eec 
Checking not only 'return 1' but also 'return var' with var = 1. That
makes these fixes more compatible.
@szapp szapp added this to Info condition (rewrite) in Fix templates Mar 15, 2021
@szapp szapp moved this from Info condition (rewrite) to Rewrite Daedalus function in Fix templates Mar 15, 2021
@szapp szapp added the impl: modify/analyze script func This issue requires analyzing and/or modifying the bytecode of script functions. label Mar 16, 2021
@szapp szapp moved this from Rewrite Daedalus function to Unsorted in Fix templates Mar 16, 2021
@szapp szapp moved this from Unsorted to Dialog: Info condition in Fix templates Mar 17, 2021
szapp added a commit that referenced this issue Mar 17, 2021
@szapp
Simplify #42 #60 #79 #122 with GetIntVar
b0835e2
szapp added a commit that referenced this issue Apr 10, 2021
@szapp
refactor: simplifiy some bytecode manipulations
e6b6295 
Refs #60 #79
AmProsius added a commit that referenced this issue Apr 20, 2021
@AmProsius
refactor: simplify test of #60
11c03e0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compatibility: easy This issue is easy to make compatible. impl: modify/analyze script func This issue requires analyzing and/or modifying the bytecode of script functions. type: session fix The fix for this issues is persistent across a session.
Projects
Fix templates
Modify dialog conditions
v1.0.0
  
Done
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

#60: Fix Jesse's quest AmProsius/gothic-1-community-patch
3 participants
@AmProsius @catalinstoian @szapp