Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPCs practice sword training without a weapon #7

Closed
AmProsius opened this issue Dec 30, 2020 · 1 comment · Fixed by #70
Closed

NPCs practice sword training without a weapon #7

AmProsius opened this issue Dec 30, 2020 · 1 comment · Fixed by #70
Labels
impl: hook script func This issue requires hooking script functions. provided fix This issue has a fix provided in the comments. type: session fix The fix for this issues is persistent across a session. validation: validated This issue is still present even with Systempack/Union.
Milestone

Comments

@AmProsius
Copy link
Owner

AmProsius commented Dec 30, 2020

Describe the bug
NPCs practice sword training without a weapon if they were defeated before and the player picked up their weapon.

Expected behavior
NPCs no longer practice weapon training without a weapon. If the player picked up their weapon after defeating them, they now stand around.

@AmProsius AmProsius added this to To Do in v1.0.0 Dec 30, 2020
@AmProsius AmProsius removed ai labels Jan 1, 2021
@catalinstoian
Copy link

catalinstoian commented Jan 9, 2021

func void ZS_PracticeSword_Loop()
{
PrintDebugNpc (PD_TA_LOOP, "ZS_PracticeSword_Loop");
AI_PlayAni (self,"T_1HSFREE");
AI_GotoWP (self, self.wp);
AI_AlignToWP (self);
};

changed to

func void ZS_PracticeSword_Loop()
{
    PrintDebugNpc       (PD_TA_LOOP,    "ZS_PracticeSword_Loop");

    if !Npc_HasReadiedMeleeWeapon(self)
    {
        //AI_StartState (self, ZS_StandAround, 1, "");
        AI_ReadyMeleeWeapon (self);
    };

    AI_PlayAni          (self,"T_1HSFREE");
    AI_GotoWP           (self, self.wp);
    AI_AlignToWP        (self);
};

szapp added a commit that referenced this issue Jan 18, 2021
@szapp szapp added the type: session fix The fix for this issues is persistent across a session. label Jan 18, 2021
@AmProsius AmProsius linked a pull request Jan 18, 2021 that will close this issue
v1.0.0 automation moved this from To Do to Done Jan 18, 2021
AmProsius added a commit that referenced this issue Jan 18, 2021
@AmProsius AmProsius added this to the v1.0.0 milestone Feb 13, 2021
@AmProsius AmProsius added provided fix This issue has a fix provided in the comments. validation: validated This issue is still present even with Systempack/Union. labels Mar 13, 2021
@szapp szapp added this to Hook Daedalus function in Fix templates Mar 15, 2021
@szapp szapp added the impl: hook script func This issue requires hooking script functions. label Mar 16, 2021
@szapp szapp moved this from Hook Daedalus function to NPC state in Fix templates Mar 16, 2021
@szapp szapp moved this from Modify NPC state to Some NPC Test? (Todo adjust name) in Fix templates Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impl: hook script func This issue requires hooking script functions. provided fix This issue has a fix provided in the comments. type: session fix The fix for this issues is persistent across a session. validation: validated This issue is still present even with Systempack/Union.
Projects
Fix templates
NPC manual test (TODO rename)
v1.0.0
  
Done
Development

Successfully merging a pull request may close this issue.

3 participants