Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wolf teaches guards dexterity instead of bandits/mercs #79

Closed
i5sue5 opened this issue Jan 25, 2021 · 1 comment · Fixed by #101
Closed

Wolf teaches guards dexterity instead of bandits/mercs #79

i5sue5 opened this issue Jan 25, 2021 · 1 comment · Fixed by #101
Labels
compatibility: easy This issue is easy to make compatible. impl: modify/analyze script func This issue requires analyzing and/or modifying the bytecode of script functions. type: session fix The fix for this issues is persistent across a session.
Milestone

Comments

@i5sue5
Copy link

i5sue5 commented Jan 25, 2021

When you've become a guard Wolf will start to teach you dexterity. This doesn't make any sense since he's a member of the new camp.

@i5sue5
Copy link
Author

i5sue5 commented Jan 25, 2021

FUNC INT ORG_855_Wolf_Teach_Condition()
{
if (Npc_GetTrueGuild (hero) == GIL_GRD)
{
return TRUE;
};
};

changed to

FUNC INT ORG_855_Wolf_Teach_Condition()
{
	if (C_NpcBelongsToNewCamp (other))
	{
		return TRUE;
	};
};

@AmProsius AmProsius added this to To Do in v1.0.0 Jan 28, 2021
@szapp szapp added compatibility: easy This issue is easy to make compatible. type: session fix The fix for this issues is persistent across a session. labels Jan 31, 2021
v1.0.0 automation moved this from To Do to Done Feb 2, 2021
AmProsius added a commit that referenced this issue Feb 2, 2021
#79: Wolf's training dialog is now properly triggered
szapp added a commit that referenced this issue Feb 7, 2021
Avoid reverting the fix if it was already applied by someone else
@AmProsius AmProsius added this to the v1.0.0 milestone Feb 9, 2021
szapp added a commit that referenced this issue Mar 13, 2021
Checking not only 'return 1' but also 'return var' with var = 1. That
makes these fixes more compatible.
@szapp szapp added this to Info condition (rewrite) in Fix templates Mar 15, 2021
@szapp szapp moved this from Info condition (rewrite) to Rewrite Daedalus function in Fix templates Mar 15, 2021
@szapp szapp added the impl: modify/analyze script func This issue requires analyzing and/or modifying the bytecode of script functions. label Mar 16, 2021
@szapp szapp moved this from Rewrite Daedalus function to Unsorted in Fix templates Mar 16, 2021
@szapp szapp moved this from Unsorted to Dialog: Info condition in Fix templates Mar 17, 2021
szapp added a commit that referenced this issue Mar 17, 2021
szapp added a commit that referenced this issue Apr 10, 2021
AmProsius added a commit that referenced this issue Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility: easy This issue is easy to make compatible. impl: modify/analyze script func This issue requires analyzing and/or modifying the bytecode of script functions. type: session fix The fix for this issues is persistent across a session.
Projects
Fix templates
Modify dialog conditions
v1.0.0
  
Done
Development

Successfully merging a pull request may close this issue.

3 participants