Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPCs freeze when fleeing #9

Closed
AmProsius opened this issue Dec 30, 2020 · 1 comment · Fixed by #74
Closed

NPCs freeze when fleeing #9

AmProsius opened this issue Dec 30, 2020 · 1 comment · Fixed by #74
Labels
impl: replace func call This issue requires replacing function calls in the scripts. provided fix This issue has a fix provided in the comments. type: session fix The fix for this issues is persistent across a session. validation: validated This issue is still present even with Systempack/Union.
Milestone

Comments

@AmProsius
Copy link
Owner

AmProsius commented Dec 30, 2020

Describe the bug
NPCs sometimes freeze while fleeing.

Expected behavior
NPCs no longer freeze while fleeing.

@AmProsius AmProsius added this to To Do in v1.0.0 Dec 30, 2020
@AmProsius AmProsius removed ai labels Jan 1, 2021
@catalinstoian
Copy link

catalinstoian commented Jan 9, 2021

//-------- Die eigentliche Flucht --------
else
{
PrintDebugNpc (PD_ZS_CHECK, "...Gegner noch zu nah dran!");
Npc_SetTarget (self, other);
Npc_GetTarget ( self);
AI_Flee (self); // ...also weiter fliehen!
AI_Wait (self, 1);
return LOOP_CONTINUE;
};

changed to

    //-------- Die eigentliche Flucht --------
    else
    {
        PrintDebugNpc   (PD_ZS_CHECK,   "...Gegner noch zu nah dran!");
        Npc_SetTarget   (self,  other);

        Npc_GetTarget   ( self);
        AI_Flee         (self);                                     // ...also weiter fliehen!
        //AI_Wait         (self,  1);
        return          LOOP_CONTINUE;
    };

@szapp szapp added the type: session fix The fix for this issues is persistent across a session. label Jan 18, 2021
szapp added a commit that referenced this issue Jan 20, 2021
@AmProsius AmProsius linked a pull request Jan 21, 2021 that will close this issue
v1.0.0 automation moved this from To Do to Done Jan 21, 2021
AmProsius added a commit that referenced this issue Jan 21, 2021
#9: Remove freeze from fleeing
@AmProsius AmProsius added this to the v1.0.0 milestone Feb 13, 2021
@AmProsius AmProsius added provided fix This issue has a fix provided in the comments. validation: validated This issue is still present even with Systempack/Union. labels Mar 13, 2021
szapp added a commit that referenced this issue Mar 13, 2021
No longer the external is hooked but its call intercepted
@szapp szapp added this to Replace function calls in Fix templates Mar 15, 2021
@szapp szapp added the impl: replace func call This issue requires replacing function calls in the scripts. label Mar 16, 2021
@szapp szapp moved this from Replace function calls to NPC state in Fix templates Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impl: replace func call This issue requires replacing function calls in the scripts. provided fix This issue has a fix provided in the comments. type: session fix The fix for this issues is persistent across a session. validation: validated This issue is still present even with Systempack/Union.
Projects
Fix templates
Modify NPC state
v1.0.0
  
Done
Development

Successfully merging a pull request may close this issue.

3 participants