New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reactivate In Extremo concert #55
Conversation
gothic-1-community-patch/scriptbase/_work/Data/Scripts/Content/Story/Chapters/B_Kapitelwechsel.d Lines 43 to 44 in 2164a25
changed to //-------- InExtremo vorbereiten --------
B_InsertInExtremo(); |
|
As far as I know the sound files are present in every installation.
I don't see a problem there or do you have a better solution? |
Here is a rough draft of how that fix will have to look: One-time checks (session):
One-time checks (world):
One-time apply (only if all above confirmed)
Apply
Revert
|
The one-time init function currently takes 38 ms on my computer, which is quite okay, considering its length. |
The implementation is a proof of concept and still very ugly. One remaining conceptual thing is the restarting of the music on saving. Because the sound-VOB is disabled on reverting, the music restarts when saving is complete. This could possibly be adjusted. Refs #55
src/Ninja/G1CP/Content/Fixes/Gamesave/fix055_ReactivateInExtremo.d
Outdated
Show resolved
Hide resolved
src/Ninja/G1CP/Content/Fixes/Gamesave/fix055_ReactivateInExtremo.d
Outdated
Show resolved
Hide resolved
src/Ninja/G1CP/Content/Fixes/Gamesave/fix055_ReactivateInExtremo.d
Outdated
Show resolved
Hide resolved
Function 'B_InsertInExtremo' in GOG version
@AmProsius Should be ready to test now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I save (or load) in front of the stage, the music of the Old Camp starts playing after the fix is reapplied. Then the In Extremo music file also starts again and the two tracks overlap each other.
Everything else works! I don't know if the music can be fixed. If not, we can merge this PR. |
I think we go with it for now. I heard there is a problem with partially overlapping music with the concert anyway, so it might not necessarily a bug of this fix. |
@AmProsius There is a wrong comparison in the fix, such that the existence of the variables gothic-1-community-patch/src/Ninja/G1CP/Content/Fixes/Gamesave/fix055_ReactivateInExtremo.d Lines 35 to 38 in a547bfa
changed to ( -1 in the comparisons)
if (varPlyingId == -1) || (varChaptrId == -1) {
MEM_Info("Necessary variables not found");
return FALSE;
}; |
(sorry if this is a wrong place to ask) How to activate it in spine? |
Just follow the steps above. There's no difference in how to play the game (Spine/Steam/Original EXE). |
Deutscher Text unten
The In Extremo concert is disabled in some versions of the game due to legal concerns. Depending on the circumstances, this fix allows to re-enable it.
Disclaimer
This fix of the G1CP does not add the concert, but merely adds the option to re-enable it yourself, provided all necessary files are present in your Gothic installation. The G1CP thereby does not provide any legally questionably files. That means, if your copy of Gothic did not ship the necessary music files and the original code to run the concert, the concert will not be available.
To further avoid any legal ambiguities, the G1CP itself does not re-activate the concert, but only offers the user to enabled it. This necessary action from the user is equivalent to the workload of opening the VDF in their Gothic installation with freely available tools and extracting the WAV file. The G1CP team thereby wants to distance itself from any legal concerns.
Enable the Concert
Given the necessary files and code are present in their exact original form, the concert can be enabled by removing the fix ID (
55
) from the disabled-list in the Gothic.ini file. Navigate to the System directory of your Gothic installation and open the file Gothic.ini with a text editor. Find the section[G1CP]
and remove the55
from the entrydisabled
. The concert should now be available in the game, during the second chapter. If not, your installation does not provide the necessary files.Example (no other disabled fixes)
Before
After
Example (with other disabled fixes)
If other fixes are disabled, leave them in the list. Exemplary fixes 23 and 144 are disabled here.
Before
After
Das In Extremo Konzert ist in manchen Kaufversionen des Spiels aus rechtlichen Gründen deaktiviert. Dieser Fix hier erlaubt es, es unter Umständen wieder zu aktivieren.
Disclaimer
Dieser Fix des G1CP fügt das Konzert nicht hinzu, sondern erlaubt lediglich es selbst wieder zu aktivieren, vorausgesetzt alle erforderlichen Dateien sind in der Gothic Installation vorhanden. Der G1CP stellt daher keinerlei legal fragliche Dateien zur Verfügung. Das bedeutet, wenn eine Installation von Gothic vorliegt, die nicht die nötigen Musikdateien und die originalen Skripte für das Konzert beinhaltet, wird das Konzert auch weiterhin nicht verfügbar sein.
Um weitere rechtliche Unklarheiten auszuschließen, aktiviert der G1CP das Konzert nicht selbst, sondern ermöglicht lediglich, dass der Nutzer es selbst aktivieren kann. Diese nötigen Schritte seitens des Nutzers sind äquivalent zum Arbeitsaufwand, die VDF-Datei in der Gothic Installation mit frei verfügbarer Software zu öffnen und die WAV-Datei zu extrahieren. Damit möchte sich das G1CP Team von möglichen rechtlichen Fragen distanzieren.
Konzert aktivieren
Vorausgesetzt alle nötigen Datein und der relevante Skriptcode sind exakt in ihrer ursprünglichen Form vorhanden, kann das Konzert re-aktiviert werden. Dazu muss die Fix ID (
55
) aus der Disabled-Liste in der Gothic.ini entfernt werden. Im System Verzeichnis der Gothic Installation befindet sich die Gothic.ini. Mit einem Texteditor lässt sich unter der Sektion[G1CP]
die55
aus dem Eintragdisabled
entfernen. Das Konzert sollte daraufhin im zweiten Kapitel des Spiels verfügbar sein. Falls das nicht der Fall ist, beinhaltet diese Gothic Installation nicht die nötigen Dateien.Beispiel (keine weiteren deaktivierten Fixes)
Vorher
Nachher
Beispiel (mit weiteren deaktivierten Fixes)
Falls andere Fixes deaktiviert sind, sollten diese einfach in der Liste verbleiben. Hier sind beispielhaft auch 23 und 144 deaktiviert.
Vorher
Nacher